Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1225)

Issue 195041: code review 195041: Bug in go/parser when coverting identifier lists. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by gri
Modified:
10 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

Bug in go/parser when coverting identifier lists. Fixes issue 567.

Patch Set 1 #

Patch Set 2 : code review 195041: Bug in go/parser when coverting identifier lists. #

Patch Set 3 : code review 195041: Bug in go/parser when coverting identifier lists. #

Patch Set 4 : code review 195041: Bug in go/parser when coverting identifier lists. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/go/parser/parser.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/parser/parser_test.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
10 years ago (2010-01-26 19:02:17 UTC) #1
rsc
LGTM
10 years ago (2010-01-26 19:40:59 UTC) #2
gri
10 years ago (2010-01-26 19:41:40 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=f6fabbdfed0c ***

Bug in go/parser when coverting identifier lists.
Fixes issue 567.

R=rsc
CC=golang-dev
http://codereview.appspot.com/195041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b