Disable automatically resizing swapchain if window is iconified

Disable automatically resizing swapchain if window is iconified

The size of the window is changed if the window is iconified, but that change should be ignored.

BUG=
R=shannonwoods@chromium.org

Committed: https://code.google.com/p/angleproject/source/detail?r=0f0edf9

[John Bauman, 2013-10-29 21:32:14]

needed for https://code.google.com/p/chromium/issues/detail?id=311673

[John Bauman, 2013-10-29 21:43:41]

On 2013/10/29 21:32:14, John Bauman wrote:
> needed for https://code.google.com/p/chromium/issues/detail?id=311673

Also https://code.google.com/p/chromium/issues/detail?id=306963

Another option would be to remove this logic immediately. It's not needed by
chromium, at least.

[Shannon Woods, 2013-10-29 21:48:25]

https://codereview.appspot.com/19460043/diff/1/src/libEGL/Surface.cpp
File src/libEGL/Surface.cpp (right):

https://codereview.appspot.com/19460043/diff/1/src/libEGL/Surface.cpp#newcode316
src/libEGL/Surface.cpp:316: // The window is automatically resized when iconic.
I'd prefer a clearer comment-- do you mean "The window is automatically resized
when it's minimized, which we're ignoring here because we don't want to resize
the swap chain to a size that isn't actually useful", or "Don't reset the swap
chain here, because the resizing is automatically handled elsewhere"? (I assume
the former?)

[Shannon Woods, 2013-10-29 22:07:49]

On 2013/10/29 21:43:41, John Bauman wrote:
> On 2013/10/29 21:32:14, John Bauman wrote:
> > needed for https://code.google.com/p/chromium/issues/detail?id=311673
> 
> Also https://code.google.com/p/chromium/issues/detail?id=306963
> 
> Another option would be to remove this logic immediately. It's not needed by
> chromium, at least.

I believe the logic is still needed for standalone windowed applications, but
jmadill@ may be more knowledgeable on that than I am.

[John Bauman, 2013-10-29 22:19:33]

On 2013/10/29 21:48:25, Shannon Woods wrote:
> https://codereview.appspot.com/19460043/diff/1/src/libEGL/Surface.cpp
> File src/libEGL/Surface.cpp (right):
> 
>
https://codereview.appspot.com/19460043/diff/1/src/libEGL/Surface.cpp#newcode316
> src/libEGL/Surface.cpp:316: // The window is automatically resized when
iconic.
> I'd prefer a clearer comment-- do you mean "The window is automatically
resized
> when it's minimized, which we're ignoring here because we don't want to resize
> the swap chain to a size that isn't actually useful", or "Don't reset the swap
> chain here, because the resizing is automatically handled elsewhere"? (I
assume
> the former?)

Ok, elaborated a bit more on the comment.

[John Bauman, 2013-10-29 22:21:03]

On 2013/10/29 22:07:49, Shannon Woods wrote:
> On 2013/10/29 21:43:41, John Bauman wrote:
> > On 2013/10/29 21:32:14, John Bauman wrote:
> > > needed for https://code.google.com/p/chromium/issues/detail?id=311673
> > 
> > Also https://code.google.com/p/chromium/issues/detail?id=306963
> > 
> > Another option would be to remove this logic immediately. It's not needed by
> > chromium, at least.
> 
> I believe the logic is still needed for standalone windowed applications, but
> jmadill@ may be more knowledgeable on that than I am.

Standalone applications subclass the window to get this info, which is fine.
What I'd really want is to avoid calling this from the end of swapRect.

[Shannon Woods, 2013-10-29 22:45:00]

LGTM!

[John Bauman, 2013-10-29 23:03:58]

Committed patchset #2 manually as r0f0edf9 (presubmit successful).