Issue 1945041: Allow HTML entities in URIs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1945041: Allow HTML entities in URIs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by chirag

Modified:
15 years, 3 months ago

Reviewers:
MikeSamuel

CC:
felix8a, google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

When Caja's ResolveUriStage resolves the source URL in a script node, the "&" gets rewritten to "&amp%3b". I have narrowed the issue down to UriUtil#normalizeQuery (correctly) escaping semicolon in query strings. ResolveUriStage#resolveRelativeUrls should be unescaping HTML entities before calling UriUtil.resolve and escaping HTML entities afterwards. Example: <html><body> <script src="http://example.com/path/?a=1&b=2"> </body></html>

Patch Set 1 #

Total comments: 1

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	src/com/google/caja/plugin/stages/ResolveUriStage.java	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	tests/com/google/caja/plugin/stages/ResolveUriStageTest.java	View		1 chunk	+16 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSamuel

15 years, 5 months ago (2010-08-16 21:13:13 UTC) #3

http://codereview.appspot.com/1945041/diff/1/2
File tests/com/google/caja/plugin/stages/ResolveUriStageTest.java (right):

http://codereview.appspot.com/1945041/diff/1/2#newcode48
tests/com/google/caja/plugin/stages/ResolveUriStageTest.java:48: job("<a
href=\"http://example.com/bar?a=1&amp;b=2\">foo</a>",
I patched these tests into a clean checkout and they run green without the
changes to ResolveUriStage.

Do you have tests that demonstrate the problem you're having?

Expand All Messages | Collapse All Messages