ticket:11491: adjust Java version check for Android.

ticket:11491: adjust Java version check for Android.

R=markus.icu@gmail.com

Committed: http://bugs.icu-project.org/trac/changeset/36978

[markus.icu, 2015-01-21 18:37:31]

LGTM

[roubert (google), 2015-01-21 18:44:19]

Hm, the repository refuses to let me submit the file for not having updated the
copyright header (despite there being no copyright header; how did the current
version get checked in):

Files lacking Copyright IBM 2015:
	icu4j/trunk/main/tests/core/src/com/ibm/icu/dev/test/bigdec/DiagBigDecimal.java

So I replaced the weird top-level comment about being generated from a file that
doesn't exist in the repository with a copyright comment like in all other files
instead. Does that look correct now?

[markus.icu, 2015-01-21 21:34:49]

https://codereview.appspot.com/194320043/diff/20001/main/tests/core/src/com/i...
File main/tests/core/src/com/ibm/icu/dev/test/bigdec/DiagBigDecimal.java
(right):

https://codereview.appspot.com/194320043/diff/20001/main/tests/core/src/com/i...
main/tests/core/src/com/ibm/icu/dev/test/bigdec/DiagBigDecimal.java:3: *
Copyright (C) 2015, International Business Machines Corporation and
Adding this copyright block is fine, but make it 2000-2015.
Please retain the two original comment lines, right after this copyright block.
Then, after those two lines, please add a comment like
// Modified since then.
or something appropriate.

That should make the copyright checker happy, retain potentially useful
information, and document that it's not exactly as generated any more.

FYI: This file has been modified before, but I guess we didn't have the
copyright checker in place yet:
http://bugs.icu-project.org/trac/log/icu4j/trunk/main/tests/core/src/com/ibm/...

[roubert (google), 2015-01-21 21:41:38]

https://codereview.appspot.com/194320043/diff/20001/main/tests/core/src/com/i...
File main/tests/core/src/com/ibm/icu/dev/test/bigdec/DiagBigDecimal.java
(right):

https://codereview.appspot.com/194320043/diff/20001/main/tests/core/src/com/i...
main/tests/core/src/com/ibm/icu/dev/test/bigdec/DiagBigDecimal.java:3: *
Copyright (C) 2015, International Business Machines Corporation and
On 2015/01/21 21:34:49, markus.icu wrote:
> Adding this copyright block is fine, but make it 2000-2015.
> Please retain the two original comment lines, right after this copyright
block.
> Then, after those two lines, please add a comment like
> // Modified since then.
> or something appropriate.
> 
> That should make the copyright checker happy, retain potentially useful
> information, and document that it's not exactly as generated any more.
> 
> FYI: This file has been modified before, but I guess we didn't have the
> copyright checker in place yet:
>
http://bugs.icu-project.org/trac/log/icu4j/trunk/main/tests/core/src/com/ibm/...

Done.

[markus.icu, 2015-01-21 21:45:09]

LGTM

[roubert (google), 2015-01-21 21:46:27]

Committed patchset #3 (id:40001) manually as 36978 (presubmit successful).