Issue 1943041: Apply linter to more files.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1943041: Apply linter to more files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by kpreid2

Modified:
15 years, 10 months ago

Reviewers:
MikeSamuel, Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Particularly, apply the linter to all of the files which go into caja-iframe.js, and adjust @provides/@requires to satisfy it.

Patch Set 1 #

Total comments: 2

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -25 lines)			Patch
M	build.xml	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/com/google/caja/cajita-module.js	View	3 chunks	+10 lines, -10 lines	0 comments	Download
M	src/com/google/caja/cajita-promise.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/host-iframe-final.js	View	1 chunk	+10 lines, -3 lines	2 comments	Download
M	src/com/google/caja/plugin/host-tools.js	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	src/com/google/caja/plugin/uri.js	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

MikeSamuel

LGTM http://codereview.appspot.com/1943041/diff/1/6 File src/com/google/caja/plugin/host-iframe-final.js (right): http://codereview.appspot.com/1943041/diff/1/6#newcode17 src/com/google/caja/plugin/host-iframe-final.js:17: * This file exists to be concatenated into ...

15 years, 10 months ago (2010-08-10 04:50:38 UTC) #2

kpreid2

15 years, 10 months ago (2010-08-10 16:52:29 UTC) #3

http://codereview.appspot.com/1943041/diff/1/6
File src/com/google/caja/plugin/host-iframe-final.js (right):

http://codereview.appspot.com/1943041/diff/1/6#newcode17
src/com/google/caja/plugin/host-iframe-final.js:17: * This file exists to be
concatenated into the single file that caja.js (the
On 2010/08/10 04:50:39, MikeSamuel wrote:
> caja.js -> cajita.js

No, the comment is correct. cajita.js is the runtime; caja.js is the library
that creates an iframe and then loads cajita.js, etc., into it.

Expand All Messages | Collapse All Messages