ticket:11483: Canonicalize IDs for java.util.TimeZone.getTimeZone().

ticket:11483: Canonicalize IDs for java.util.TimeZone.getTimeZone().

Committed: http://bugs.icu-project.org/trac/changeset/36988

[roubert (google), 2015-01-26 21:43:55]

Do you have any comments, or should I submit this?

[yoshito_umaoka_us.ibm.com, 2015-01-26 22:02:42]

Sorry for slow response.

I'm not sure this is a good change or not.

"Canonical ID" is not based on the tz database - it's basically what CLDR 
defines. A canonical ID in CLDR might be already deprecated. Oracle's Java 
currently include the tz database, including deprecated IDs (backward 
file), so it still works. But it will break if someone decide to ignore 
backward zones.

I think it should always try the given ID (from the specified ICU time 
zone - because it was either originated from JRE, or user) first, instead 
of canonicalizing it beforehand. If JRE does not recognize it, then, try 
"canonicalized" ID (if different).

-Yoshito




From:   roubert@google.com
To:     yoshito_umaoka@us.ibm.com
Cc:     markus.icu@gmail.com, reply@codereview-hr.appspotmail.com
Date:   01/26/2015 04:44 PM
Subject:        ticket:11483: Canonicalize IDs for 
java.util.TimeZone.getTimeZone(). (issue 194240043 by roubert@google.com)



Reviewers: yoshito_umaoka_us.ibm.com,

Message:
Do you have any comments, or should I submit this?

Description:
ticket:11483: Canonicalize IDs for java.util.TimeZone.getTimeZone().

Please review this at https://codereview.appspot.com/194240043/

Affected files (+5, -1 lines):
   M main/classes/core/src/com/ibm/icu/util/TimeZone.java


Index: main/classes/core/src/com/ibm/icu/util/TimeZone.java
diff --git a/main/classes/core/src/com/ibm/icu/util/TimeZone.java 
b/main/classes/core/src/com/ibm/icu/util/TimeZone.java
index 
15b7ecf90e6f508a012e3969b9cf557baaf574dd..f8765f81801ff795ca67b2a1c3f1afbf883bf4a0

 
100644
--- a/main/classes/core/src/com/ibm/icu/util/TimeZone.java
+++ b/main/classes/core/src/com/ibm/icu/util/TimeZone.java
@@ -963,7 +963,11 @@ abstract public class TimeZone implements 
Serializable, Cloneable, Freezable<Tim
                      // getDSTSavings() when the instance of JDK TimeZone
                      // is not an instance of JDK internal TimeZone 
subclass
                      // (sun.util.calendar.ZoneInfo).  Ticket#6459
-                    String icuID = tz.getID();
+                    // Always canonicalize the ID before passing it to
+                    // java.util.TimeZone, as there is no guarantee that
+                    // abbreviations for JDK 1.1.x compatibility are 
supported
+                    // in every execution environment.
+                    String icuID = getCanonicalID(tz.getID());
                      jdkZone = java.util.TimeZone.getTimeZone(icuID);
                      if (!icuID.equals(jdkZone.getID())) {
                          // JDK does not know the ID..

[roubert (google), 2015-01-27 00:29:06]

Like this?

[yoshito_umaoka_us.ibm.com, 2015-01-27 01:33:01]

Yes. I like it better.

Thanks,
Yoshito

roubert@google.com wrote on 01/26/2015 07:29:06 PM:

> From: roubert@google.com
> To: yoshito_umaoka@us.ibm.com
> Cc: markus.icu@gmail.com, reply@codereview-hr.appspotmail.com
> Date: 01/26/2015 07:29 PM
> Subject: Re: ticket:11483: Canonicalize IDs for 
> java.util.TimeZone.getTimeZone(). (issue 194240043 by 
roubert@google.com)
> 
> Like this?
> 
> https://codereview.appspot.com/194240043/
> 

[roubert (google), 2015-01-27 10:55:27]

Committed patchset #3 (id:40001) manually as 36988 (presubmit successful).