Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1350)

Issue 194147: Fixes in westin_sheen closure (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by aconty
Modified:
12 years ago
Reviewers:
osl-dev, ckulla
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

We were forgetting to set the pdf in the eval function, plus we were using the wrong cosine in its sampler.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
src/liboslexec/bsdf_westin.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
aconty
13 years ago (2010-01-30 02:16:32 UTC) #1
ckulla
13 years ago (2010-02-01 16:01:58 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b