Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1145)

Issue 194142: Review: nan/inf checking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by larrygritz
Modified:
13 years ago
Reviewers:
ckulla
CC:
dev-osl_imageworks.com, osl-dev_googlegroups.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This change allows a debug mode (set by attribute("debugnan",1)) that checks every value written by each instruction, and if any nan or inf values are found, issues a warning pointing to exactly which shader source line it happened on. It's quite expensive, nobody should use it for ordinary rendering, but it's real helpful if you are trying to debug NaNs in your renderer, this will quickly narrow it down to the particular instruction. (SPI folks: a corresponding renderer-side review will come to you shortly.)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -7 lines) Patch
src/liboslexec/exec.cpp View 3 chunks +41 lines, -6 lines 0 comments Download
src/liboslexec/oslexec_pvt.h View 3 chunks +7 lines, -0 lines 0 comments Download
src/liboslexec/shadingsys.cpp View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3
larrygritz
13 years ago (2010-01-29 19:42:34 UTC) #1
ckulla
How about checking the results of geometry binding as well? Otherwise LGTM
13 years ago (2010-01-29 20:20:50 UTC) #2
lg_imageworks.com
13 years ago (2010-01-29 20:40:30 UTC) #3
You mean checking all the inputs?  Sure.  But let me check this one in first.


On Jan 29, 2010, at 12:20 PM, <ckulla@gmail.com> wrote:

> How about checking the results of geometry binding as well?
> 
> Otherwise LGTM
> 
> http://codereview.appspot.com/194142/show
> 

--
Larry Gritz
lg@imageworks.com




Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b