Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94)

Issue 194117: Review: smarter runflags for lazy eval (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by larrygritz
Modified:
13 years ago
Reviewers:
aconty, ckulla
CC:
dev-osl_imageworks.com, osl-dev_googlegroups.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

If you called context->execute() with a "sparse" set of runflags (such as if you were picking the subset of a set of rays that hit objects with the same shaders), it would use those runflags for any unconditionally-run layers, but lazy layer evaluation was done with all points on, which is very wasteful for sparse run sets. This change records the top-level original runflags passed in, and uses those runflags when running upstream layers lazily.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
src/liboslexec/context.cpp View 1 chunk +1 line, -0 lines 0 comments Download
src/liboslexec/exec.cpp View 5 chunks +13 lines, -15 lines 0 comments Download
src/liboslexec/oslexec_pvt.h View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4
larrygritz
13 years ago (2010-01-27 22:56:15 UTC) #1
aconty
LGTM
13 years ago (2010-01-27 23:20:06 UTC) #2
ckulla
LGTM2 Can't wait to see the difference on those benchmark cases.
13 years ago (2010-01-27 23:22:32 UTC) #3
larrygritz
13 years ago (2010-01-27 23:25:34 UTC) #4
On 2010/01/27 23:22:32, ckulla wrote:
> Can't wait to see the difference on those benchmark cases.

OK, I committed it, so give it a try.
This should throw into even more stark relief the waste associated with sparse
runflags.  I'll tackle that after "rebind" is done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b