Issue 194099: code review 194099: avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8c

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 194099: code review 194099: avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8c (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by dpx

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8c

Patch Set 2 : code review 194099: avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8c #

Total comments: 3

Patch Set 3 : code review 194099: avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8c #

Patch Set 4 : code review 194099: avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8c #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -8 lines)			Patch
M	src/cmd/5a/a.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/5a/lex.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/6a/a.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/6a/lex.c	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8a/a.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/8a/lex.c	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/cc/cc.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	src/cmd/cc/lex.c	View	1 2 3	4 chunks	+19 lines, -2 lines	0 comments	Download
M	src/cmd/cc/lexbody	View	1 2 3	3 chunks	+18 lines, -2 lines	0 comments	Download
M	src/cmd/cc/macbody	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dpx

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-01-27 02:50:54 UTC) #1

rsc1

looks good; nice and clean a few comments http://codereview.appspot.com/194099/diff/12/1018 File src/cmd/cc/lex.c (right): http://codereview.appspot.com/194099/diff/12/1018#newcode1592 src/cmd/cc/lex.c:1592: ensuresymb(int32 ...

14 years, 3 months ago (2010-01-28 23:20:21 UTC) #2

dpx

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2010-01-28 23:59:35 UTC) #3

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=77806cd76a0b *** avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8c R=rsc CC=golang-dev http://codereview.appspot.com/194099 ...

14 years, 3 months ago (2010-01-29 00:11:40 UTC) #4

LGTM

Thanks

Expand All Messages | Collapse All Messages