code review 194097: gc: implement defer print/println/panic/panicln

gc: implement defer print/println/panic/panicln

Fixes issue 219.

[rsc, 2010-01-27 01:49:13]

Hello ken2, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-01-27 01:51:50]

this makes defer println(1,"hello") work by turning it into
(approximately) defer printf("%d %s\n", 1, "hello")
where printf is a runtime function otherwise inaccessible
from go.

the drawback is that printf needed a couple more verbs,
but again you can't get at it from go.

russ

[r, 2010-01-27 01:56:17]

http://codereview.appspot.com/194097/diff/8/12
File src/pkg/runtime/print.c (right):

http://codereview.appspot.com/194097/diff/8/12#newcode35
src/pkg/runtime/print.c:35: // Do not add to this without checking with Rob.
comment now out of date.

http://codereview.appspot.com/194097/diff/8/12#newcode72
src/pkg/runtime/print.c:72: narg = arg + 1;
really? they're packed?

http://codereview.appspot.com/194097/diff/8/14
File test/golden.out (right):

http://codereview.appspot.com/194097/diff/8/14#newcode28
test/golden.out:28: =========== ./deferprint.go
is deferprint missing from the CL?

[rsc, 2010-01-27 02:23:24]

> http://codereview.appspot.com/194097/diff/8/12#newcode35
> src/pkg/runtime/print.c:35: // Do not add to this without checking with
> Rob.
> comment now out of date.

moved down to vprintf.

>
> http://codereview.appspot.com/194097/diff/8/12#newcode72
> src/pkg/runtime/print.c:72: narg = arg + 1;
> really? they're packed?

yep.  added to the test to make sure.

>
> http://codereview.appspot.com/194097/diff/8/14
> File test/golden.out (right):
>
> http://codereview.appspot.com/194097/diff/8/14#newcode28
> test/golden.out:28: =========== ./deferprint.go
> is deferprint missing from the CL?

yep.

fixed and uploaded.
russ

[r, 2010-01-27 02:25:19]

LGTM

[rsc, 2010-01-27 23:37:12]

*** Submitted as http://code.google.com/p/go/source/detail?r=6f9125fefea6 ***

gc: implement defer print/println/panic/panicln

Fixes issue 219.

R=ken2, r
CC=golang-dev
http://codereview.appspot.com/194097

[ken3, 2010-01-27 23:47:50]

LGTM

On 2010/01/27 23:37:12, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=6f9125fefea6 ***
> 
> gc: implement defer print/println/panic/panicln
> 
> Fixes issue 219.
> 
> R=ken2, r
> CC=golang-dev
> http://codereview.appspot.com/194097