Issue 194072: code review 194072: in C and asm, replace pkg·name with ·name

Issue 194072: code review 194072: in C and asm, replace pkg·name with ·name (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by rsc

Modified:
16 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

in C and asm, replace pkg·name with ·name (eliminate assumption of package global name space, make code easier to move between packages).

Patch Set 1 #

Patch Set 2 : code review 194072: in C and asm, replace pkg·name with ·name #

Patch Set 3 : code review 194072: in C and asm, replace pkg·name with ·name #

Created: 16 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+416 lines, -416 lines)			Patch
M	src/pkg/big/arith_386.s	View	1 2	7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/big/arith_amd64.s	View	1 2	7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/pkg/big/arith_arm.s	View	1 2	1 chunk	+14 lines, -14 lines	0 comments	Download
M	src/pkg/bignum/arith_amd64.s	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/bytes/asm_386.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/bytes/asm_amd64.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/bytes/asm_arm.s	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/asin_386.s	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/atan_386.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/exp_386.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/fabs_386.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/floor_386.s	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/log_386.s	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/sin_386.s	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/math/sqrt_386.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/sqrt_amd64.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/math/tan_386.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/386/asm.s	View	1 2	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/386/closure.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/386/traceback.c	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/386/vlrt.c	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/amd64/asm.s	View	1 2	4 chunks	+25 lines, -25 lines	0 comments	Download
M	src/pkg/runtime/amd64/closure.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/amd64/traceback.c	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/arm/asm.s	View	1 2	5 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/arm/closure.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/arm/traceback.c	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/arm/vlrt.c	View	1 2	6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/cgocall.c	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/chan.c	View	1 2	27 chunks	+53 lines, -53 lines	0 comments	Download
M	src/pkg/runtime/darwin/386/sys.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/darwin/amd64/sys.s	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/darwin/thread.c	View	1 2	6 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pkg/runtime/freebsd/386/sys.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/sys.s	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/runtime/hashmap.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/hashmap.c	View	1 2	15 chunks	+37 lines, -37 lines	0 comments	Download
M	src/pkg/runtime/iface.c	View	1 2	18 chunks	+20 lines, -20 lines	0 comments	Download
M	src/pkg/runtime/linux/386/sys.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/linux/amd64/sys.s	View	1 2	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/linux/arm/sys.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/linux/thread.c	View	1 2	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/mingw/386/sys.s	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/nacl/386/sys.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/pchw/mem.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/pchw/thread.c	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/print.c	View	1 2	8 chunks	+21 lines, -21 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1 2	11 chunks	+14 lines, -14 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2	3 chunks	+18 lines, -18 lines	0 comments	Download
M	src/pkg/runtime/runtime.c	View	1 2	8 chunks	+11 lines, -11 lines	0 comments	Download
M	src/pkg/runtime/sigqueue.cgo	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/slice.c	View	1 2	8 chunks	+54 lines, -54 lines	0 comments	Download
M	src/pkg/runtime/string.cgo	View	1 2	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/sync/asm_386.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/sync/asm_amd64.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/sync/asm_arm.s	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/syscall/asm_darwin_386.s	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/asm_darwin_amd64.s	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/asm_freebsd_386.s	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/asm_freebsd_amd64.s	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/asm_linux_386.s	View	1 2	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/syscall/asm_linux_amd64.s	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/asm_linux_arm.s	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/asm_nacl_386.s	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

16 years, 8 months ago (2010-01-26 02:43:16 UTC) #1

rsc

16 years, 8 months ago (2010-01-26 02:52:58 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=2d8f69ef707f ***

in C and asm, replace pkg·name with ·name
(eliminate assumption of package global name space,
make code easier to move between packages).

R=r
CC=golang-dev
http://codereview.appspot.com/194072

Expand All Messages | Collapse All Messages