Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1107)

Issue 194067: Review: string routine drives me crazy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by larrygritz
Modified:
13 years ago
Reviewers:
ckulla
CC:
dev-osl_imageworks.com, osl-dev_googlegroups.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Many times I've been plagued by inexplicable crashes in loadshader.cpp, right at the call to boost::starts_with. I've wasted hours and hours and been unable to figure out why it boost::startswith(x,y) should fail when x and y are valid std::strings. So I finally wrote my own (trivially) just to see if that happens, and I no longer crash. (Making me able to move on to the real crash I'm supposed to be debugging. :-)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
src/liboslexec/loadshader.cpp View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7
larrygritz
13 years ago (2010-01-25 23:34:09 UTC) #1
ckulla
On 2010/01/25 23:34:09, larrygritz wrote: > LGTM, but this is quite mysterious. Were the crashes ...
13 years ago (2010-01-25 23:38:06 UTC) #2
brian.budge
Hi Larry - Just to be robust, would it make sense to make sure that ...
13 years ago (2010-01-25 23:51:23 UTC) #3
lg_imageworks.com
Either email or by going to the link below and commenting using the review tool. ...
13 years ago (2010-01-26 00:04:57 UTC) #4
lg_imageworks.com
Wow, what do you know, apparently if you reply via email and don't change any ...
13 years ago (2010-01-26 00:06:32 UTC) #5
brian.budge
Nice. You're correct, there's no robustness issue, I just had a brain-blip. On Mon, Jan ...
13 years ago (2010-01-26 00:08:33 UTC) #6
lg_imageworks.com
13 years ago (2010-01-26 00:09:40 UTC) #7
OS X.  I haven't seen it on Linux, but I'm not sure that means much.

It's black magic to be sure, but I just can't justify spending any more time
tracking down this red herring when I have legit bugs to pursue.

	-- lg


On Jan 25, 2010, at 3:38 PM, <ckulla@gmail.com> wrote:

> On 2010/01/25 23:34:09, larrygritz wrote:
> 
> 
> LGTM, but this is quite mysterious. Were the crashes on OS X or linux?
> 
> http://codereview.appspot.com/194067/show
> 

--
Larry Gritz
lg@imageworks.com




Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b