code review 194053: runtime, type switch: eliminate package global name spa...

src/pkg/reflect/value.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package reflect
 
 import (
         "runtime"
         "unsafe"
 )
@@ skipping 934 matching lines @@
         if t == nil || i < 0 || i >= len(t.methods) {
                 return nil
         }
         p := &t.methods[i]
 
         // Interface is two words: itable, data.
         tab := *(**runtime.Itable)(v.addr)
         data := &value{Typeof((*byte)(nil)), addr(uintptr(v.addr) + ptrSize), true}
 
         // Function pointer is at p.perm in the table.
-        fn := tab.Fn[p.perm]
+        fn := tab.Fn[i]
         fv := &FuncValue{value: value{toType(*p.typ), addr(&fn), true}, first: data, isInterface: true}
         return fv
 }
 
 /*
  * map
  */
 
 // A MapValue represents a map value.
 type MapValue struct {
@@ skipping 314 matching lines @@
         panicln("newValue", typ.String())
 }
 
 // MakeZero returns a zero Value for the specified Type.
 func MakeZero(typ Type) Value {
         if typ == nil {
                 return nil
         }
         return newValue(typ, addr(unsafe.New(typ)), true)
 }