Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 194049: Experimental patch: Separate quick render of html from slower javascript execution (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by Jasvir
Modified:
13 years, 4 months ago
CC:
shindig.remailer_gmail.com
Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

SanitizingGadgetRewriter neuters a gadget by removing all css, all javascript and those html tags that aren't on its whitelist. This is used "to create a simple badge like display" useful when low latency and inactive content is require - for example for a view with many gadgets. This patch provides a lower latency alternative for caja gadgets. It: * immediately renders the html and inline css portions of a gadget creating the "badge like display" SanitizingGadgetRewriter does * adds a button to the top of the gadget which when clicked "rehydrates" the gadget and executes all the javascript and renders remaining css styles

Patch Set 1 #

Total comments: 1

Patch Set 2 : Snapshot to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M features/src/main/javascript/features/caja/taming.js View 1 1 chunk +27 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Jasvir
* patch currently contains the http://codereview.appspot.com/194041/show - I'll snapshot to remove that once its committed. ...
15 years, 7 months ago (2010-01-25 00:19:40 UTC) #1
Jasvir
15 years, 7 months ago (2010-01-25 00:22:33 UTC) #2
http://codereview.appspot.com/194049/diff/1/9
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/194049/diff/1/9#newcode124
features/src/main/javascript/features/caja/taming.js:124:
___.setNewModuleHandler(delayedLoader);
Using the delayedLoader vs the immediateLoader decides whether the gadget
javascript is executed immediately or not.  Suggestions welcome about how a
container can configure this perhaps depending on what view of the gadget is
being rendered.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b