Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89)

Issue 194041: Upgrade caja and add tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 7 months ago by Jasvir
Modified:
15 years, 7 months ago
Reviewers:
Paul Lindner
CC:
shindig.remailer_gmail.com
Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

* upgrades Caja version * reverts the xmlnamespaces features in Caja till we switch to CajaHtmlParser entirely * restores caja test * adds tests that rerun existing end to end tests cajoled * Three failing CajaSocialMarkupHtmlParserTest that depend on namespacing are marked ignored. @903122

Patch Set 1 #

Patch Set 2 : Upgrade caja and add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -17 lines) Patch
M features/src/main/javascript/features/core.util/taming.js View 1 chunk +1 line, -0 lines 0 comments Download
M features/src/main/javascript/features/opensocial-reference/taming.js View 1 2 chunks +6 lines, -0 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/CajaSocialMarkupHtmlParserTest.java View 2 chunks +17 lines, -0 lines 0 comments Download
M java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java View 1 5 chunks +34 lines, -3 lines 0 comments Download
M java/server/src/test/resources/endtoend/cajaTest.xml View 1 chunk +12 lines, -13 lines 0 comments Download
M java/server/src/test/resources/endtoend/failCajaTest.xml View 1 chunk +1 line, -0 lines 0 comments Download
M pom.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
Paul Lindner
15 years, 7 months ago (2010-01-26 06:34:34 UTC) #1
lgtm!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b