Fix build on QNX.

Fix build on QNX.

InfoSink.h needs stdlib.h for abs(int) and free() in the global namespace.

ExpressionParser needs malloc.h, because bison needs malloc and free in
the global namespace, but "#include <cassert>" will put it only in the
std:: namespace on QNX.

BUG=500

[Geoff Lang, 2013-10-29 20:26:59]

LGTM

[Geoff Lang, 2013-10-29 20:29:04]

Also, can you add shannonwoods@chromium.org as a reviewer (be sure to add a
message such as "PTAL" so she gets an email)?

[efidler1, 2013-10-29 20:30:46]

PTAL

[Shannon Woods, 2013-10-29 21:00:35]

On 2013/10/29 20:30:46, efidler1 wrote:
> PTAL

LGTM! Thank you. One of us will land this shortly.

[Jamie Madill, 2013-10-30 21:58:42]

On 2013/10/29 21:00:35, Shannon Woods wrote:
> On 2013/10/29 20:30:46, efidler1 wrote:
> > PTAL
> 
> LGTM! Thank you. One of us will land this shortly.

Landed as r817951245a5d, please mark as closed.

[Zhenyao Mo, 2013-11-01 00:08:57]

https://codereview.appspot.com/19330044/diff/1/src/compiler/preprocessor/Expr...
File src/compiler/preprocessor/ExpressionParser.cpp (right):

https://codereview.appspot.com/19330044/diff/1/src/compiler/preprocessor/Expr...
src/compiler/preprocessor/ExpressionParser.cpp:95: #include <malloc.h>
Include this file causes Mac builds to fail compiling:

http://build.chromium.org/p/tryserver.chromium/builders/mac_rel/builds/183364...

[Zhenyao Mo, 2013-11-01 00:10:54]

See examples in chromium:
https://code.google.com/p/chromium/codesearch#chromium/src/base/memory/aligne...

[efidler1, 2013-11-01 01:27:19]

My apologies. stdlib.h should be fine for QNX instead of malloc.h, so that block
should work. I'll try to verify locally.

[efidler1, 2013-11-01 03:17:03]

confirmed, using the version from base/memory/aligned_memory.h works for QNX.
I'm not set up to test on Windows.

#if defined(COMPILER_MSVC)
#include <malloc.h>
#else
#include <stdlib.h>
#endif

[Zhenyao Mo, 2013-11-01 03:22:10]

On 2013/11/01 03:17:03, efidler1 wrote:
> confirmed, using the version from base/memory/aligned_memory.h works for QNX.
> I'm not set up to test on Windows.
> 
> #if defined(COMPILER_MSVC)
> #include <malloc.h>
> #else
> #include <stdlib.h>
> #endif

Great!  Can you upload a CL? So we can roll a few ANGLE CLs into chromium
tomorrow, hopefully making the chrome m32 cut.

[efidler1, 2013-11-01 14:54:39]

uploaded

[Jamie Madill, 2013-11-01 15:05:54]

On 2013/11/01 14:54:39, efidler1 wrote:
> uploaded

LGTM... going to land unless there's any objections from zmo.

[Zhenyao Mo, 2013-11-01 17:09:48]

https://codereview.appspot.com/19330044/diff/20001/src/compiler/preprocessor/...
File src/compiler/preprocessor/ExpressionParser.cpp (right):

https://codereview.appspot.com/19330044/diff/20001/src/compiler/preprocessor/...
src/compiler/preprocessor/ExpressionParser.cpp:95: #if defined(COMPILER_MSVC)
Actually it should be _MSC_VER

COMPILER_MSVC is a chromium def that's based on _MSC_VER

https://codereview.appspot.com/19330044/diff/20001/src/compiler/preprocessor/...
File src/compiler/preprocessor/ExpressionParser.y (right):

https://codereview.appspot.com/19330044/diff/20001/src/compiler/preprocessor/...
src/compiler/preprocessor/ExpressionParser.y:36: #if defined(COMPILER_MSVC)
Same here.  _MSC_VER

[efidler1, 2013-11-01 17:46:37]

updated

[Zhenyao Mo, 2013-11-01 20:11:09]

On 2013/11/01 17:46:37, efidler1 wrote:
> updated

LGTM
thanks

[Jamie Madill, 2013-11-04 15:19:31]

On 2013/11/01 20:11:09, Zhenyao Mo wrote:
> On 2013/11/01 17:46:37, efidler1 wrote:
> > updated
> 
> LGTM
> thanks

landed... efidler1, can you close this review? (under edit issue) I don't have
permission.