Conversion of stock_suppy to Transaction

[pheller, 2010-08-09 02:43:23]

http://codereview.appspot.com/1932041/diff/1/4
File purchase_request.py (right):

http://codereview.appspot.com/1932041/diff/1/4#newcode382
purchase_request.py:382: with
Transaction().set_context(stock_date_start=current_date,
Note that local_context was unused in the trunk implementation....  should this
call to products_by_location use the local context?

[ced, 2010-08-09 13:51:37]

http://codereview.appspot.com/1932041/diff/1/4
File purchase_request.py (right):

http://codereview.appspot.com/1932041/diff/1/4#newcode150
purchase_request.py:150: stock_date_end = min_date or datetime.date.max,
No space around =

http://codereview.appspot.com/1932041/diff/1/4#newcode151
purchase_request.py:151: stock_skip_warehouse = True):
idem

http://codereview.appspot.com/1932041/diff/1/4#newcode152
purchase_request.py:152: pbl = product_obj.products_by_location(warehouse_ids,
trailing space?

http://codereview.appspot.com/1932041/diff/1/4#newcode245
purchase_request.py:245: quantity = uom_obj.compute_qty(old_req['uom'],
trailing space?

http://codereview.appspot.com/1932041/diff/1/4#newcode290
purchase_request.py:290: product_quantity, company, order_point=None):
Could be re-indent with 8 spaces

http://codereview.appspot.com/1932041/diff/1/4#newcode382
purchase_request.py:382: with
Transaction().set_context(stock_date_start=current_date,
On 2010/08/09 02:43:23, pheller wrote:
> Note that local_context was unused in the trunk implementation....  should
this
> call to products_by_location use the local context?

I guess yes.

http://codereview.appspot.com/1932041/diff/1/4#newcode508
purchase_request.py:508: ('party', '=', False)
, at the end

http://codereview.appspot.com/1932041/diff/1/4#newcode517
purchase_request.py:517: 'supplier_payment_term': form['payment_term']
, at the end

http://codereview.appspot.com/1932041/diff/1/4#newcode573
purchase_request.py:573: with Transaction().set_user(0):
Missing with_context=True

http://codereview.appspot.com/1932041/diff/1/4#newcode578
purchase_request.py:578: with Transaction().set_user(0):
Could done in one with statement

http://codereview.appspot.com/1932041/diff/1/4#newcode606
purchase_request.py:606: local_context = context.copy()
Could be removed

http://codereview.appspot.com/1932041/diff/1/5
File shipment.py (right):

http://codereview.appspot.com/1932041/diff/1/5#newcode38
shipment.py:38: ('type', '=', 'internal')
Missing , at the end

http://codereview.appspot.com/1932041/diff/1/5#newcode47
shipment.py:47: with Transaction().set_context(stock_date_end = today):
No space around =

http://codereview.appspot.com/1932041/diff/1/5#newcode65
shipment.py:65: ('planned_date', '=', False)
Missing ending ,

http://codereview.appspot.com/1932041/diff/1/5#newcode66
shipment.py:66: ]
Missing ending ,

[ced, 2010-08-09 14:31:18]

Still comments for shipment.py

[ced, 2010-08-09 14:38:35]

Ok for me