Please review. A demo showing the desired result can be found here: http://clairnote.org / lilypond-web-demo2/ ...
10 years, 2 months ago
(2015-01-14 18:12:54 UTC)
#1
Please review. A demo showing the desired result can be found here:
http://clairnote.org / lilypond-web-demo2/
(just remove the two spaces in the url)
Things should look the same in IE8 and IE9 as in other browsers.
I will also need to add some images to the lilypond-extras repo that go with
this revision. These are the Lily icon used in the LilyPond ("home") tab:
lily-home-32x32.png
and these gradient images used as fallbacks for IE9 and lower:
nav1-bg.png
nav1-hover.png
nav1-active.png
nav2-bg.png
nav2-hover.png
nav2-active.png
The images are now included in this patch for lilypond-git and also in a pull-request ...
10 years, 2 months ago
(2015-01-15 04:32:19 UTC)
#2
The images are now included in this patch for lilypond-git and also in a
pull-request to the lilypond-extra repo. (From the CG I got the impression that
they only went in lilypond-extra, but on second glance it appears that they live
in both places.)
On 2015/01/15 04:32:19, pwm wrote: > The images are now included in this patch for ...
10 years, 2 months ago
(2015-01-16 09:25:19 UTC)
#3
On 2015/01/15 04:32:19, pwm wrote:
> The images are now included in this patch for lilypond-git and also in a
> pull-request to the lilypond-extra repo. (From the CG I got the impression
that
> they only went in lilypond-extra, but on second glance it appears that they
live
> in both places.)
Fails to apply to current master.
Please also make sure that when you make a new patch set you change the tracker
label to patch-new so that it gets tested automatically.
On 2015/01/16 09:25:19, J_lowe wrote: > > Fails to apply to current master. > > ...
10 years, 2 months ago
(2015-01-16 15:37:09 UTC)
#4
On 2015/01/16 09:25:19, J_lowe wrote:
>
> Fails to apply to current master.
>
> Please also make sure that when you make a new patch set you change the
tracker
> label to patch-new so that it gets tested automatically.
Ok, trying again with patch set #4. See also message I just sent to
lilypond-devel.
On 2015/01/16 15:37:09, pwm wrote: > On 2015/01/16 09:25:19, J_lowe wrote: > > > > ...
10 years, 2 months ago
(2015-01-16 18:26:07 UTC)
#5
On 2015/01/16 15:37:09, pwm wrote:
> On 2015/01/16 09:25:19, J_lowe wrote:
> >
> > Fails to apply to current master.
> >
> > Please also make sure that when you make a new patch set you change the
> tracker
> > label to patch-new so that it gets tested automatically.
>
> Ok, trying again with patch set #4. See also message I just sent to
> lilypond-devel.
You forgot to set the tracker to patch-new ;)
OK I still got failed to apply to current master when using the automatic
scripts which should just scrape the download raw file from here.
Manually downloading and applying the raw patch worked and I ran the tests
manually, they all passed including a full make doc so issue 4258 is now under
official review.
On 2015/01/16 18:26:07, J_lowe wrote: > > You forgot to set the tracker to patch-new ...
10 years, 2 months ago
(2015-01-17 16:59:29 UTC)
#6
On 2015/01/16 18:26:07, J_lowe wrote:
>
> You forgot to set the tracker to patch-new ;)
>
> OK I still got failed to apply to current master when using the automatic
> scripts which should just scrape the download raw file from here.
>
> Manually downloading and applying the raw patch worked and I ran the tests
> manually, they all passed including a full make doc so issue 4258 is now under
> official review.
Ok, sounds good. Thanks for running the tests manually.
On 2015/01/17 16:59:29, pwm wrote: > On 2015/01/16 18:26:07, J_lowe wrote: > > > > ...
10 years, 2 months ago
(2015-01-19 18:20:49 UTC)
#7
On 2015/01/17 16:59:29, pwm wrote:
> On 2015/01/16 18:26:07, J_lowe wrote:
> >
> > You forgot to set the tracker to patch-new ;)
> >
> > OK I still got failed to apply to current master when using the automatic
> > scripts which should just scrape the download raw file from here.
> >
> > Manually downloading and applying the raw patch worked and I ran the tests
> > manually, they all passed including a full make doc so issue 4258 is now
under
> > official review.
>
> Ok, sounds good. Thanks for running the tests manually.
Patch on countdown for Jan 22nd
Issue 193140043: Web: revise navigation bars with CSS gradients
(Closed)
Created 10 years, 2 months ago by pwm
Modified 10 years, 2 months ago
Reviewers: pkx166h
Base URL: http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Comments: 0