Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(293)

Issue 193079: code review 193079: gc: cut some dead code, fix 6g -S output (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by rsc
Modified:
14 years, 2 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

gc: cut some dead code, fix 6g -S output

Patch Set 1 #

Patch Set 2 : code review 193079: gc: cut some dead code, fix 6g -S output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -54 lines) Patch
M src/cmd/gc/export.c View 1 chunk +0 lines, -51 lines 0 comments Download
M src/cmd/gc/go.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gc/go.y View 1 chunk +0 lines, -1 line 0 comments Download
M src/cmd/gc/lex.c View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 2 months ago (2010-01-25 06:36:23 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=cfe42eb9c75a *** gc: cut some dead code, fix 6g -S output R=ken2 ...
14 years, 2 months ago (2010-01-25 06:36:28 UTC) #2
ken3
14 years, 2 months ago (2010-01-25 06:48:08 UTC) #3
LGTM

On 2010/01/25 06:36:28, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=cfe42eb9c75a ***
> 
> gc: cut some dead code, fix 6g -S output
> 
> R=ken2
> CC=golang-dev
> http://codereview.appspot.com/193079
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b