Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1665)

Issue 193060: random-variable - doc updated and new Zeta distribution (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Tommaso Pecorella
Modified:
4 years, 2 months ago
Reviewers:
Mathieu Lacage
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Closed issue, merged with ns-3-dev

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixed Mathieu's points #

Patch Set 3 : fixed last stuff as per Michele Weigle comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+996 lines, -663 lines) Patch
M src/core/random-variable.h View 1 2 37 chunks +175 lines, -135 lines 0 comments Download
M src/core/random-variable.cc View 1 2 44 chunks +821 lines, -528 lines 0 comments Download

Messages

Total messages: 6
Mathieu Lacage
looks good modulo very minor style details. you might find the check-style.py script helpful. Also, ...
4 years, 3 months ago #1
Tommaso Pecorella
Done, I'll reupload everything later tonight. Both random-variable.cc and random-variable.h had more indentation and such ...
4 years, 3 months ago #2
Tommaso Pecorella
4 years, 3 months ago #3
Tommaso Pecorella
Dammit, I forgot to update the revisions number, so there are two spurious files in ...
4 years, 3 months ago #4
Tommaso Pecorella
Opened a bug to keep track of this patch: Bug 797
4 years, 3 months ago #5
Tommaso Pecorella
4 years, 2 months ago #6

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5