Issue 1923043: code review 1923043: goinstall: check for error from exec.*Cmd.Wait() before...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1923043: code review 1923043: goinstall: check for error from exec.*Cmd.Wait() before... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by brainman

Modified:
14 years, 7 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

goinstall: check for error from exec.*Cmd.Wait() before using its result

Patch Set 1 #

Patch Set 2 : code review 1923043: goinstall: check for error from exec.*Cmd.Wait() before... #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/cmd/goinstall/main.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 7 months ago (2010-08-05 00:14:30 UTC) #1

rsc

14 years, 7 months ago (2010-08-05 00:19:00 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a573ec0c1065 ***

goinstall: check for error from exec.*Cmd.Wait() before using its result

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/1923043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages