Issue 1918044: Converting sale_price_list to Transaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1918044: Converting sale_price_list to Transaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by pheller

Modified:
15 years, 2 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : reverted from instantiating a function scoped variable "context" #

Total comments: 3

Patch Set 3 : adjusted unnecessary context gets back to dict key access, fixed logic w/ line break #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -24 lines)			Patch
M	INSTALL	View		1 chunk	+1 line, -1 line	0 comments	Download
M	product.py	View	1 2	1 chunk	+10 lines, -11 lines	0 comments	Download
M	sale.py	View		3 chunks	+8 lines, -12 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/1918044/diff/1/3 File product.py (right): http://codereview.appspot.com/1918044/diff/1/3#newcode12 product.py:12: context = Transaction().context Don't like because it can be ...

15 years, 2 months ago (2010-08-06 05:48:41 UTC) #1

ced

http://codereview.appspot.com/1918044/diff/4001/5002 File product.py (right): http://codereview.appspot.com/1918044/diff/4001/5002#newcode14 product.py:14: if Transaction().context.get('price_list') and \ Better to use () and ...

15 years, 2 months ago (2010-08-06 14:15:32 UTC) #3

Ok for me

Expand All Messages | Collapse All Messages