Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1445)

Issue 1917046: Update project_plan modules for new Transaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by timitos
Modified:
15 years, 5 months ago
Reviewers:
ced, rmu
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix arguments of get_function_fields #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -149 lines) Patch
M INSTALL View 1 chunk +1 line, -1 line 0 comments Download
M allocation.py View 3 chunks +17 lines, -25 lines 0 comments Download
M work.py View 1 23 chunks +95 lines, -123 lines 1 comment Download

Messages

Total messages: 5
ced
http://codereview.appspot.com/1917046/diff/1/4 File work.py (right): http://codereview.appspot.com/1917046/diff/1/4#newcode80 work.py:80: def get_function_fields(self, cids, names): ids
15 years, 6 months ago (2010-08-05 21:31:10 UTC) #1
timitos
15 years, 6 months ago (2010-08-06 06:16:28 UTC) #2
ced
Ok for me
15 years, 6 months ago (2010-08-06 06:33:35 UTC) #3
rmu
found typo in project_plan http://codereview.appspot.com/1917046/diff/4001/5003 File work.py (right): http://codereview.appspot.com/1917046/diff/4001/5003#newcode91 work.py:91: cursor = Transation().cursor s/Transation/Transaction/
15 years, 5 months ago (2010-09-03 18:42:51 UTC) #4
ced
15 years, 5 months ago (2010-09-03 19:04:38 UTC) #5
On 2010/09/03 18:42:51, rmu wrote:
> found typo in project_plan
> 
> http://codereview.appspot.com/1917046/diff/4001/5003
> File work.py (right):
> 
> http://codereview.appspot.com/1917046/diff/4001/5003#newcode91
> work.py:91: cursor = Transation().cursor
> s/Transation/Transaction/

Fixed but please don't report issue on closed review.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b