Issue 1915043: code review 1915043: misc/vim: highlight misspelled words only in comments

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1915043: code review 1915043: misc/vim: highlight misspelled words only in comments (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by chressie

Modified:
14 years, 7 months ago

Reviewers:

CC:
adg, golang-dev

Visibility:
Public.

Description

misc/vim: highlight misspelled words only in comments

Patch Set 1 #

Patch Set 2 : code review 1915043: misc/vim: highlight misspelled words only in comments #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	misc/vim/syntax/go.vim	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

chressie

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-08-04 09:14:29 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=cc5165478d69 *** misc/vim: highlight misspelled words only in comments R=adg CC=golang-dev http://codereview.appspot.com/1915043 ...

14 years, 7 months ago (2010-08-05 00:31:06 UTC) #2

adg

14 years, 7 months ago (2010-08-05 00:31:15 UTC) #3

LGTM

On 4 August 2010 19:14,  <chressie@googlemail.com> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> misc/vim: highlight misspelled words only in comments
>
> Please review this at http://codereview.appspot.com/1915043/show
>
> Affected files:
>  M misc/vim/syntax/go.vim
>
>
> Index: misc/vim/syntax/go.vim
> ===================================================================
> --- a/misc/vim/syntax/go.vim
> +++ b/misc/vim/syntax/go.vim
> @@ -95,8 +95,8 @@
>  " Comments; their contents
>  syn keyword     goTodo              contained TODO FIXME XXX BUG
>  syn cluster     goCommentGroup      contains=goTodo
> -syn region      goComment           start="/\*" end="\*/"
> contains=@goCommentGroup
> -syn region      goComment           start="//" end="$"
> contains=@goCommentGroup
> +syn region      goComment           start="/\*" end="\*/"
> contains=@goCommentGroup,@Spell
> +syn region      goComment           start="//" end="$"
> contains=@goCommentGroup,@Spell
>
>  hi def link     goComment           Comment
>  hi def link     goTodo              Todo
>
>
>

Expand All Messages | Collapse All Messages