Issue 191480043: ticket:11464: TestFmwk should log closing brace lines for empty tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 191480043: ticket:11464: TestFmwk should log closing brace lines for empty tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by roubert (google)

Modified:
9 years, 11 months ago

Reviewers:
yoshito_umaoka

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu4j/trunk

Visibility:
Public.

More Reviews

Description

ticket:11464: TestFmwk should log closing brace lines for empty tests. Committed: http://bugs.icu-project.org/trac/changeset/36927

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	main/tests/framework/src/com/ibm/icu/dev/test/TestFmwk.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

roubert (google)

Committed patchset #1 (id:1) manually as 36927 (presubmit successful).

9 years, 11 months ago (2015-01-07 18:39:36 UTC) #1

yoshito_umaoka_us.ibm.com

9 years, 11 months ago (2015-01-07 20:59:02 UTC) #2

Thanks.

The fix looks fine to me. Please commit the change to the ICU4J 
repository.

-Yoshito

roubert@google.com wrote on 01/07/2015 01:39:36 PM:

> From: roubert@google.com
> To: yoshito_umaoka@us.ibm.com
> Cc: reply@codereview-hr.appspotmail.com
> Date: 01/07/2015 01:39 PM
> Subject: ticket:11464: TestFmwk should log closing brace lines for 
> empty tests. (issue 191480043 by roubert@google.com)
> 
> Reviewers: yoshito_umaoka_us.ibm.com,
> 
> Message:
> Committed patchset #1 (id:1) manually as 36927 (presubmit successful).
> 
> Description:
> ticket:11464: TestFmwk should log closing brace lines for empty tests.
> 
> Committed: http://bugs.icu-project.org/trac/changeset/36927
> 
> Please review this at https://codereview.appspot.com/191480043/
> 
> Affected files (+5, -0 lines):
>    M main/tests/framework/src/com/ibm/icu/dev/test/TestFmwk.java
> 
> 
> Index: main/tests/framework/src/com/ibm/icu/dev/test/TestFmwk.java
> diff --git a/main/tests/framework/src/com/ibm/icu/dev/test/TestFmwk.java 
 
> b/main/tests/framework/src/com/ibm/icu/dev/test/TestFmwk.java
> index 
> 79e1e328eb7d75fe56943f7c95e440393ff6afe1..
> 7e170d7c560f369ae251824eea1657ef3b9eecfb 
> 100644
> --- a/main/tests/framework/src/com/ibm/icu/dev/test/TestFmwk.java
> +++ b/main/tests/framework/src/com/ibm/icu/dev/test/TestFmwk.java
> @@ -1652,6 +1652,11 @@ public class TestFmwk extends AbstractTestLog {
> 
>               int testDelta = testCount - stack.tc;
>               if (testDelta == 0) {
> +                if (stack.included) {
> +                    stack.flush();
> +                    indent(indentLevel);
> +                    log.println("} (0s) Empty");
> +                }
>                   return;
>               }
> 
> 
>

Expand All Messages | Collapse All Messages