Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1375)

Issue 190960043: ticket:11018: Refactor date format string mapping code (ICU4J) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by roubert (google)
Modified:
10 years ago
Reviewers:
tkeep
Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu4j/trunk
Visibility:
Public.

Description

ticket:11018: Refactor date format string mapping code (ICU4J) To make this code more maintainable: Make mapping tables zero based, add a table to tell if a character can be used to define a field in a format string (instead of now rather long-winded character range expressions) and make all lookup tables accessed through helper functions. R=rocketman@google.com Committed: http://bugs.icu-project.org/trac/changeset/36900

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -52 lines) Patch
M main/classes/core/src/com/ibm/icu/text/SimpleDateFormat.java View 12 chunks +87 lines, -52 lines 1 comment Download

Messages

Total messages: 3
roubert (google)
10 years ago (2014-12-15 18:38:35 UTC) #1
tkeep
Thanks for all of this work fredrick. Looks good to me. https://codereview.appspot.com/190960043/diff/1/main/classes/core/src/com/ibm/icu/text/SimpleDateFormat.java File main/classes/core/src/com/ibm/icu/text/SimpleDateFormat.java (right): ...
10 years ago (2014-12-15 20:49:50 UTC) #2
roubert (google)
10 years ago (2014-12-19 07:28:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 36900 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b