Issue 1909044: Convernsion of modules_currency to new Transaction style

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1909044: Convernsion of modules_currency to new Transaction style (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by pheller

Modified:
15 years, 5 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : fixes per ced's notes #

Total comments: 1

Patch Set 3 : removed redundant en_US logic #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -236 lines)			Patch
M	INSTALL	View		1 chunk	+1 line, -1 line	0 comments	Download
M	currency.py	View	1 2	10 chunks	+46 lines, -54 lines	0 comments	Download
M	tests/test_currency.py	View	1	3 chunks	+164 lines, -181 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/1909044/diff/1/3 File currency.py (right): http://codereview.appspot.com/1909044/diff/1/3#newcode6 currency.py:6: import time move standard module import up http://codereview.appspot.com/1909044/diff/1/3#newcode206 currency.py:206: ...

15 years, 6 months ago (2010-07-30 16:37:29 UTC) #1

ced

http://codereview.appspot.com/1909044/diff/5001/6002 File currency.py (right): http://codereview.appspot.com/1909044/diff/5001/6002#newcode206 currency.py:206: for code in [Transaction().language or 'en_US', 'en_US']: No need ...

15 years, 6 months ago (2010-08-03 18:08:34 UTC) #3

Ok for me

Expand All Messages | Collapse All Messages