Issue 1902046: FYI: Rollback of r981658 for performance; alternate solution added.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1902046: FYI: Rollback of r981658 for performance; alternate solution added. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by johnfargo

Modified:
15 years, 7 months ago

Reviewers:
gagan.goku, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

@see comments in: http://codereview.appspot.com/1689055 Alternate solution implemented in AccelResponseRewriterRegistry. This file needs a test!

Patch Set 1 #

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+18 lines, -19 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/AccelResponseRewriterRegistry.java	View	2 chunks	+17 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/DomWalker.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/DomWalkerTest.java	View	2 chunks	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

johnfargo

Committed as r981702. Happy to take comments and improvements however.

15 years, 7 months ago (2010-08-02 23:06:57 UTC) #2

gagan.goku

15 years, 7 months ago (2010-08-03 04:02:17 UTC) #3

On 2010/08/02 23:06:57, johnfargo wrote:
> Committed as r981702. Happy to take comments and improvements however.

Hi John

As mentioned in the other code review, it would be better to make this code
change in DefaultResponseRewriterRegistry.
Also, we should add a test for the same.

Expand All Messages | Collapse All Messages