Issue 1902043: code review 1902043: CONTRIBUTORS: add wcn@google.com alias to match with co...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1902043: code review 1902043: CONTRIBUTORS: add wcn@google.com alias to match with co... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rsc

Modified:
14 years, 7 months ago

Reviewers:

CC:
Bill Neubauer, golang-dev

Visibility:
Public.

Description

CONTRIBUTORS: add wcn@google.com alias to match with code review

Patch Set 1 #

Patch Set 2 : code review 1902043: CONTRIBUTORS: add wcn@google.com alias to match with co... #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	CONTRIBUTORS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello wcn (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-07-30 17:07:44 UTC) #1

Bill Neubauer

On 2010/07/30 17:07:44, rsc wrote: > Hello wcn (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

14 years, 7 months ago (2010-07-30 19:17:07 UTC) #2

Bill Neubauer

On 2010/07/30 19:17:07, wcn wrote: > On 2010/07/30 17:07:44, rsc wrote: > > Hello wcn ...

14 years, 7 months ago (2010-07-30 19:19:43 UTC) #3

rsc

>> LGTM > > Might as well remove the other one? The syntax (having two) ...

14 years, 7 months ago (2010-07-30 19:26:32 UTC) #4

rsc

14 years, 7 months ago (2010-07-30 19:26:52 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=7cdd17894c8e ***

CONTRIBUTORS: add wcn@google.com alias to match with code review

R=wcn
CC=golang-dev
http://codereview.appspot.com/1902043

Expand All Messages | Collapse All Messages