Issue 190080043: ticket:11018: Refactor date format string mapping code (ICU4C)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 190080043: ticket:11018: Refactor date format string mapping code (ICU4C) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by roubert (google)

Modified:
9 years, 11 months ago

Reviewers:
tkeep

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu/trunk

Visibility:
Public.

More Reviews

Description

ticket:11018: Refactor date format string mapping code (ICU4C) To make this code more maintainable: Make mapping tables zero based, add a table to tell if a character can be used to define a field in a format string (instead of now rather long-winded character range expressions) and make all lookup tables accessed through helper functions. R=rocketman@google.com Committed: http://bugs.icu-project.org/trac/changeset/36899

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -74 lines)			Patch
	M	source/i18n/smpdtfmt.cpp	View		8 chunks	+105 lines, -73 lines	0 comments	Download
	M	source/i18n/unicode/smpdtfmt.h	View		1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

roubert (google)

9 years, 11 months ago (2014-12-19 07:28:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 36899 (presubmit successful).

Expand All Messages | Collapse All Messages