Issue 190067: Added PyFunctionObject and PyMethodObject to PyTypeBuilder

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 190067: Added PyFunctionObject and PyMethodObject to PyTypeBuilder (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 1 month ago by ebo

Modified:
16 years ago

Reviewers:
collinwinter, Reid Kleckner, Jeffrey Yasskin

CC:
unladen-swallow_googlegroups.com

Base URL:
http://unladen-swallow.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Both are needed for inlineing.

Patch Set 1 #

Total comments: 2

Created: 16 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -3 lines)			Patch
M	Include/classobject.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	Include/funcobject.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	Python/llvm_inline_functions.c	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	Util/PyTypeBuilder.h	View	2 chunks	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

collinwinter

16 years ago (2010-02-01 19:42:48 UTC) #2

LGTM, with comments.

http://codereview.appspot.com/190067/diff/1/3
File Include/classobject.h (right):

http://codereview.appspot.com/190067/diff/1/3#newcode30
Include/classobject.h:30: typedef struct PyMethodObject {
Please add a comment here, "If you change this, update Util/PyTypeBuilder.h
accordingly."

http://codereview.appspot.com/190067/diff/1/4
File Include/funcobject.h (right):

http://codereview.appspot.com/190067/diff/1/4#newcode21
Include/funcobject.h:21: typedef struct PyFunctionObject {
Please add a comment here, "If you change this, update Util/PyTypeBuilder.h
accordingly."

Expand All Messages | Collapse All Messages