Improve switch view

- Don't fetch all records when new fields are added by views, re-fetch records only if new fields are displayed.
- Use some list comprehension.
- Use dictionaries to prevent double for loop.

[h.goebel, 2010-01-19 11:56:13]

http://codereview.appspot.com/190051/diff/1/2
File tryton/gui/window/view_form/model/group.py (right):

http://codereview.appspot.com/190051/diff/1/2#newcode180
tryton/gui/window/view_form/model/group.py:180: for model in
list(self.model_deleted):
use self.model_deleted[:], since you are copying.
"list(...)" looks like a type change.

[h.goebel, 2010-01-19 12:00:05]

http://codereview.appspot.com/190051/diff/1/3
File tryton/gui/window/view_form/model/record.py (right):

http://codereview.appspot.com/190051/diff/1/3#newcode60
tryton/gui/window/view_form/model/record.py:60: if name not in self._loaded and
self.id > 0:
see below

http://codereview.appspot.com/190051/diff/1/3#newcode68
tryton/gui/window/view_form/model/record.py:68: if name not in model._loaded and
model.id > 0:
should be more efficient:
if model.id > 0 and not name in model_loaded

http://codereview.appspot.com/190051/diff/1/3#newcode72
tryton/gui/window/view_form/model/record.py:72: if name not in model._loaded and
model.id > 0:
see above

http://codereview.appspot.com/190051/diff/1/3#newcode94
tryton/gui/window/view_form/model/record.py:94: if model.id in id2value:
value = id2value.get(model.id, None)
if value:
  ...

[ced, 2010-01-19 12:28:09]

http://codereview.appspot.com/190051/diff/1/3
File tryton/gui/window/view_form/model/record.py (right):

http://codereview.appspot.com/190051/diff/1/3#newcode68
tryton/gui/window/view_form/model/record.py:68: if name not in model._loaded and
model.id > 0:
On 2010/01/19 12:00:05, h.goebel wrote:
> should be more efficient:
> if model.id > 0 and not name in model_loaded

model.id > 0 is rarest case