Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(102)

Issue 1897046: code review 1897046: bikeshed: only output bug when we have a regression (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 7 months ago by kaib
Modified:
14 years, 7 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

bikeshed: only output bug when we have a regression

Patch Set 1 #

Patch Set 2 : code review 1897046: bikeshed: only output bug when we have a regression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/run View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
kaib
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 7 months ago (2010-07-30 09:26:56 UTC) #1
kaib
It seemed to me like the only part you are objecting to is when we ...
14 years, 7 months ago (2010-07-30 09:36:01 UTC) #2
rsc
On Fri, Jul 30, 2010 at 02:36, <kaib@golang.org> wrote: > It seemed to me like ...
14 years, 7 months ago (2010-07-30 15:19:31 UTC) #3
kaib
On Fri, Jul 30, 2010 at 6:19 PM, Russ Cox <rsc@golang.org> wrote: > On Fri, ...
14 years, 7 months ago (2010-07-30 21:21:23 UTC) #4
rsc
LGTM > The output from run happens while the tests are in progress. With arm ...
14 years, 7 months ago (2010-07-30 22:26:15 UTC) #5
rsc
14 years, 7 months ago (2010-08-03 20:09:18 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=76aa09a38d7f ***

bikeshed: only output bug when we have a regression

R=rsc
CC=golang-dev
http://codereview.appspot.com/1897046

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b