Issue 1897045: Update product module for new Transaction

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1897045: Update product module for new Transaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by sharoonthomas

Modified:
15 years, 5 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : Changed {}.get(key) to {}[key] #

Total comments: 1

Patch Set 3 : Added missed out import CONTEXT #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -210 lines)			Patch
M	INSTALL	View		1 chunk	+1 line, -1 line	0 comments	Download
M	category.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	product.py	View	1	5 chunks	+27 lines, -36 lines	0 comments	Download
M	tests/test_product.py	View	1 2	6 chunks	+106 lines, -123 lines	0 comments	Download
M	uom.py	View		8 chunks	+36 lines, -48 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/1897045/diff/1/4 File product.py (right): http://codereview.appspot.com/1897045/diff/1/4#newcode59 product.py:59: Transaction().context.get('uom')) Can use [] instead of get

15 years, 6 months ago (2010-07-29 20:41:04 UTC) #1

pheller

Looks like sharoon made the change per your comment but didn't --send_mail

15 years, 6 months ago (2010-08-03 18:07:42 UTC) #2

ced

http://codereview.appspot.com/1897045/diff/3001/4004 File tests/test_product.py (right): http://codereview.appspot.com/1897045/diff/3001/4004#newcode15 tests/test_product.py:15: from trytond.tests.test_tryton import POOL, DB_NAME, USER, test_view Missing CONTEXT ...

15 years, 6 months ago (2010-08-10 13:41:23 UTC) #4

Ok for me

Expand All Messages | Collapse All Messages