Removing unnecessary System.err.println calls

A few newly introduced System.err.println calls end up printing out lot of stuff in CssResponseRewriter and ScriptTagProxyEmbeddedUrlsVisitor - removing these since they seem to be mostly for debugging.

[gagan.goku, 2010-07-29 16:09:42]

On 2010/07/29 15:39:24, anupama.dutta wrote:
> 

lgtm++

[anupama.dutta, 2010-07-29 16:57:18]

Resending the code review request mail.

[Jasvir, 2010-07-29 19:08:39]

LGTM

[chirag, 2010-07-29 19:23:27]

http://codereview.appspot.com/1897044/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java
(right):

http://codereview.appspot.com/1897044/diff/1/3#newcode167
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:167:
LOG.fine("Entering rewrite chain.node=" + chain.node);
Minor nit.

We could check if the given level is fine beforehand to save a string
concatenation.

if (LOG.isLoggable(Level.FINE)) {
  LOG.fine("Entering rewrite chain.node=" + chain.node);
}

http://codereview.appspot.com/1897044/diff/1/3#newcode171
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:171:
LOG.fine("Import: uriLiteral.getValue() ");
Should we also emit the value in the log?

[Jasvir, 2010-07-29 19:30:29]

Actually both these logging statements can probably just be deleted.

[anupama.dutta, 2010-07-30 03:05:47]

Removing the System.err.println lines completely.

[anupama.dutta, 2010-07-30 03:06:08]

http://codereview.appspot.com/1897044/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java
(right):

http://codereview.appspot.com/1897044/diff/1/3#newcode167
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:167:
LOG.fine("Entering rewrite chain.node=" + chain.node);
On 2010/07/29 19:23:27, chirag wrote:
> Minor nit.
> 
> We could check if the given level is fine beforehand to save a string
> concatenation.
> 
> if (LOG.isLoggable(Level.FINE)) {
>   LOG.fine("Entering rewrite chain.node=" + chain.node);
> }

Removed the complete line as per Jasvir's suggestion.

http://codereview.appspot.com/1897044/diff/1/3#newcode171
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:171:
LOG.fine("Import: uriLiteral.getValue() ");
On 2010/07/29 19:23:27, chirag wrote:
> Should we also emit the value in the log?

Removed the complete line as per Jasvir's suggestion.

[chirag, 2010-07-30 03:27:25]

LGTM

On 2010/07/30 03:06:08, anupama.dutta wrote:
> http://codereview.appspot.com/1897044/diff/1/3
> File
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java
> (right):
> 
> http://codereview.appspot.com/1897044/diff/1/3#newcode167
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:167:
> LOG.fine("Entering rewrite chain.node=" + chain.node);
> On 2010/07/29 19:23:27, chirag wrote:
> > Minor nit.
> > 
> > We could check if the given level is fine beforehand to save a string
> > concatenation.
> > 
> > if (LOG.isLoggable(Level.FINE)) {
> >   LOG.fine("Entering rewrite chain.node=" + chain.node);
> > }
> 
> Removed the complete line as per Jasvir's suggestion.
> 
> http://codereview.appspot.com/1897044/diff/1/3#newcode171
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CssResponseRewriter.java:171:
> LOG.fine("Import: uriLiteral.getValue() ");
> On 2010/07/29 19:23:27, chirag wrote:
> > Should we also emit the value in the log?
> 
> Removed the complete line as per Jasvir's suggestion.

[anupama.dutta, 2010-08-02 13:44:53]

Ping! Please commit :)

Thanks,
Anupama.

[Jasvir, 2010-08-02 16:15:47]

Applied.  Thank you for the patch.