Add ibus panel icon for plasma-desktop in KDE5.

Add ibus panel icon for plasma-desktop in KDE5

plasma-desktop does not provide notification area for GtkStatusIcon
(QSystemTrayIcon too).
KDE5 provides AppIndicator or KStatusNotifierItem.
KStatusNotifierItem uses QT5 code and C++.
AppIndicator is an instance using dbus methods of
KStatusNotifierItem and it supports GTK3.
This implements the dbus method names directly so that activate menu
is supported.

http://blog.martin-graesslin.com/blog/2014/06/where-are-my-systray-icons/
https://lists.fedoraproject.org/pipermail/devel/2014-June/199782.html
http://comments.gmane.org/gmane.comp.kde.devel.core/81971

BUG=https://code.google.com/p/ibus/issues/detail?id=1749
TEST=ui/appindicator/ibus-ui-appindicator

[Peng, 2015-02-04 15:34:30]

On 2015/01/19 09:50:14, fujiwara wrote:

Could you upload a screenshot for this new ui element?

[Peng, 2015-02-04 15:35:31]

https://codereview.appspot.com/189680044/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/189680044/diff/1/ui/gtk3/panel.vala#newcode43
ui/gtk3/panel.vala:43: #if INDICATOR
Can we detect INDICATOR at the runtime instead of ./configure? So we could have
a single panel supports both gnome and kde.

https://codereview.appspot.com/189680044/diff/1/ui/gtk3/panel.vala#newcode909
ui/gtk3/panel.vala:909: #if INDICATOR
#if !INDICATOR?

[fujiwara, 2015-02-06 12:07:10]

Here is the screenshot:
https://fujiwara.fedorapeople.org/ibus/20150206/ibus-indicator.png

https://codereview.appspot.com/189680044/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/189680044/diff/1/ui/gtk3/panel.vala#newcode43
ui/gtk3/panel.vala:43: #if INDICATOR
On 2015/02/04 15:35:31, Peng wrote:
> Can we detect INDICATOR at the runtime instead of ./configure? So we could
have
> a single panel supports both gnome and kde.

Done.

[Peng, 2015-02-06 16:51:16]

https://codereview.appspot.com/189680044/diff/20001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/189680044/diff/20001/ui/gtk3/panel.vala#newcode94
ui/gtk3/panel.vala:94: init_status_icon();
Seems whatever, you will init status icon. So what will happen if icon type is
indictor? Will indictor and status icon coexist?

[fujiwara, 2015-02-09 12:53:10]

https://codereview.appspot.com/189680044/diff/20001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/189680044/diff/20001/ui/gtk3/panel.vala#newcode94
ui/gtk3/panel.vala:94: init_status_icon();
On 2015/02/06 16:51:16, Peng wrote:
> Seems whatever, you will init status icon. So what will happen if icon type is
> indictor? Will indictor and status icon coexist?

Updated.
if KDE4, use configure
if KDE5 on xterm, set environment valuable.

[Peng, 2015-02-11 16:40:19]

lgtm with several comments

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcode96
ui/gtk3/panel.vala:96: if (is_kde())
add {}

if () {
} else {
}

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:593: else if (m_icon_type == IconType.INDICATOR) {
} else if () {

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:600: m_indicator.set_status(Indicator.Status.PASSIVE);
if () {
} else {
}

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:656: else if (m_icon_type == IconType.INDICATOR) {
} else if {

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1248: else if (m_icon_type == IconType.INDICATOR) {
} else if () {

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1268: else if (m_icon_type == IconType.INDICATOR) {
} else if () {

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1278: else if (m_icon_type == IconType.INDICATOR) {
} else if () {

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1285: else if (m_icon_type == IconType.INDICATOR) {
} else if () {

[fujiwara, 2015-02-19 10:23:05]

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcode96
ui/gtk3/panel.vala:96: if (is_kde())
On 2015/02/11 16:40:18, Peng wrote:
> add {}
> 
> if () {
> } else {
> }

Done.

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:593: else if (m_icon_type == IconType.INDICATOR) {
On 2015/02/11 16:40:18, Peng wrote:
> } else if () {

Done.

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:600: m_indicator.set_status(Indicator.Status.PASSIVE);
On 2015/02/11 16:40:18, Peng wrote:
> if () {
> } else {
> }

Done.

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:656: else if (m_icon_type == IconType.INDICATOR) {
On 2015/02/11 16:40:18, Peng wrote:
> } else if {

Done.

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1248: else if (m_icon_type == IconType.INDICATOR) {
On 2015/02/11 16:40:18, Peng wrote:
> } else if () {

Done.

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1268: else if (m_icon_type == IconType.INDICATOR) {
On 2015/02/11 16:40:18, Peng wrote:
> } else if () {

Done.

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1278: else if (m_icon_type == IconType.INDICATOR) {
On 2015/02/11 16:40:18, Peng wrote:
> } else if () {

Done.

https://codereview.appspot.com/189680044/diff/40001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1285: else if (m_icon_type == IconType.INDICATOR) {
On 2015/02/11 16:40:18, Peng wrote:
> } else if () {

Done.