ticket:11474: Identify Android as a Java vendor in unit tests.

ticket:11474: Identify Android as a Java vendor in unit tests.

R=markus.icu@gmail.com

Committed: http://bugs.icu-project.org/trac/changeset/36961

[markus.icu, 2015-01-14 19:09:01]

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
File main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneBoundaryTest.java
(right):

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneBoundaryTest.java:3: *
Copyright (C) 2000-2010, International Business Machines Corporation and    *
copyright see comment in last file

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneBoundaryTest.java:443:
if (TestUtil.getJavaVendor() != JavaVendor.Android && TestUtil.getJavaVersion()
<= 3) {
It looks like the original check is for TestUtil.getJavaVersion() > 3 not <= 3.

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
File main/tests/core/src/com/ibm/icu/dev/test/util/CurrencyTest.java (right):

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
main/tests/core/src/com/ibm/icu/dev/test/util/CurrencyTest.java:3: * Copyright
(c) 2002-2014, International Business Machines
copyright see comment in last file

https://codereview.appspot.com/189550043/diff/60001/main/tests/framework/src/...
File main/tests/framework/src/com/ibm/icu/dev/test/TestUtil.java (right):

https://codereview.appspot.com/189550043/diff/60001/main/tests/framework/src/...
main/tests/framework/src/com/ibm/icu/dev/test/TestUtil.java:3: * Copyright (C)
2001-2011, International Business Machines Corporation and    *
update copyright to end in 2015
personally, when I do that, I remove the trailing '*' on this and the next
line...

[roubert (google), 2015-01-14 22:50:52]

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
File main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneBoundaryTest.java
(right):

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneBoundaryTest.java:3: *
Copyright (C) 2000-2010, International Business Machines Corporation and    *
On 2015/01/14 19:09:01, markus.icu wrote:
> copyright see comment in last file

Done.

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
main/tests/core/src/com/ibm/icu/dev/test/timezone/TimeZoneBoundaryTest.java:443:
if (TestUtil.getJavaVendor() != JavaVendor.Android && TestUtil.getJavaVersion()
<= 3) {
On 2015/01/14 19:09:01, markus.icu wrote:
> It looks like the original check is for TestUtil.getJavaVersion() > 3 not <=
3.

Oops, I read it all backwards. Changed now.

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
File main/tests/core/src/com/ibm/icu/dev/test/util/CurrencyTest.java (right):

https://codereview.appspot.com/189550043/diff/60001/main/tests/core/src/com/i...
main/tests/core/src/com/ibm/icu/dev/test/util/CurrencyTest.java:3: * Copyright
(c) 2002-2014, International Business Machines
On 2015/01/14 19:09:01, markus.icu wrote:
> copyright see comment in last file

Done.

https://codereview.appspot.com/189550043/diff/60001/main/tests/framework/src/...
File main/tests/framework/src/com/ibm/icu/dev/test/TestUtil.java (right):

https://codereview.appspot.com/189550043/diff/60001/main/tests/framework/src/...
main/tests/framework/src/com/ibm/icu/dev/test/TestUtil.java:3: * Copyright (C)
2001-2011, International Business Machines Corporation and    *
On 2015/01/14 19:09:01, markus.icu wrote:
> update copyright to end in 2015
> personally, when I do that, I remove the trailing '*' on this and the next
> line...

Done.

[markus.icu, 2015-01-14 22:54:56]

Otherwise LGTM

https://codereview.appspot.com/189550043/diff/80001/main/tests/framework/src/...
File main/tests/framework/src/com/ibm/icu/dev/test/TestUtil.java (right):

https://codereview.appspot.com/189550043/diff/80001/main/tests/framework/src/...
main/tests/framework/src/com/ibm/icu/dev/test/TestUtil.java:3: * Copyright (C)
2001-2011, International Business Machines Corporation and    *
fix copyright line

[roubert (google), 2015-01-15 10:45:17]

Committed patchset #5 (id:80001) manually as 36961 (presubmit successful).

[markus.icu, 2015-01-15 16:53:51]

On Thu, Jan 15, 2015 at 2:45 AM, <roubert@google.com> wrote:

> Committed patchset #5 (id:80001) manually as 36961 (presubmit
> successful).
>

It fails on a couple of platforms, please look into it. Maybe Yoshito and
Steven can help.

http://bugs.icu-project.org/trac/build/icu4j

markus

[roubert (google), 2015-01-15 16:56:13]

On Thu, Jan 15, 2015 at 5:53 PM, Markus Scherer <markus.icu@gmail.com> wrote:

> It fails on a couple of platforms,

Those errors don't seem to be related to the changes I made.

-- 
Fredrik Roubert
roubert@google.com