Runtime &renderDebug= for common container

Also, make use of shindig.uri more widely.

[mhermanto, 2010-08-25 17:35:58]

Update patch

[zhoresh, 2010-08-25 20:40:03]

http://codereview.appspot.com/1895047/diff/12001/13003
File features/src/main/javascript/features/container/container.js (right):

http://codereview.appspot.com/1895047/diff/12001/13003#newcode49
features/src/main/javascript/features/container/container.js:49: 'deb'));
Since it is overwrite the 'renderDebug' flag in config, it would be best to
default to 'renderDebug' instead of 'deb'

http://codereview.appspot.com/1895047/diff/12001/13003#newcode55
features/src/main/javascript/features/container/container.js:55:
this.renderDebug_ = Boolean(reqDebug ||
Instead of oring the config and url param, I think it would be better to let the
url param overwrite the config if present (meaning config=1 but param=0 then
flag will be false).

[mhermanto, 2010-08-26 17:59:06]

Addressing comments.

[mhermanto, 2010-08-26 17:59:12]

On Wed, Aug 25, 2010 at 1:40 PM, <zhoresh@gmail.com> wrote:

>
> http://codereview.appspot.com/1895047/diff/12001/13003
> File features/src/main/javascript/features/container/container.js
> (right):
>
> http://codereview.appspot.com/1895047/diff/12001/13003#newcode49
> features/src/main/javascript/features/container/container.js:49:
> 'deb'));
> Since it is overwrite the 'renderDebug' flag in config, it would be best
> to default to 'renderDebug' instead of 'deb'
>

Done.


> http://codereview.appspot.com/1895047/diff/12001/13003#newcode55
> features/src/main/javascript/features/container/container.js:55:
> this.renderDebug_ = Boolean(reqDebug ||
> Instead of oring the config and url param, I think it would be better to
> let the url param overwrite the config if present (meaning config=1 but
> param=0 then flag will be false).
>
> Done.


>
> http://codereview.appspot.com/1895047/
>

[zhoresh, 2010-08-26 20:17:05]

lgtm

http://codereview.appspot.com/1895047/diff/20001/21003
File features/src/main/javascript/features/container/container.js (right):

http://codereview.appspot.com/1895047/diff/20001/21003#newcode49
features/src/main/javascript/features/container/container.js:49:
'renderDebug'));
Maybe use the constant shindig.container.ContainerConfig.RENDER_DEBUG

[mhermanto, 2010-08-27 01:03:36]

Addressing comments.

[mhermanto, 2010-08-27 01:04:37]

On Thu, Aug 26, 2010 at 1:17 PM, <zhoresh@gmail.com> wrote:

> lgtm
>
>
> http://codereview.appspot.com/1895047/diff/20001/21003
>
> File features/src/main/javascript/features/container/container.js
> (right):
>
> http://codereview.appspot.com/1895047/diff/20001/21003#newcode49
>
> features/src/main/javascript/features/container/container.js:49:
> 'renderDebug'));
> Maybe use the constant shindig.container.ContainerConfig.RENDER_DEBUG
>
>
> Done. Good call. Re-uploaded patch. Please help commit. Thanks!



> http://codereview.appspot.com/1895047/
>

[zhoresh, 2010-08-27 01:13:01]

committed as r989993