Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2444)

Issue 189460043: ticket:11467: Promote time separator interfaces to public API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by roubert (google)
Modified:
9 years, 9 months ago
Reviewers:
markus.icu
Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu/trunk
Visibility:
Public.

Description

ticket:11467: Promote time separator interfaces to public API. R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/37043

Patch Set 1 #

Patch Set 2 : Rebased on top of current trunk. #

Total comments: 6

Patch Set 3 : Surround draft API with #ifndef U_HIDE_DRAFT_API. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M source/i18n/unicode/dtfmtsym.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M source/i18n/unicode/ucal.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M source/i18n/unicode/udat.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5
roubert (google)
9 years, 9 months ago (2015-02-17 15:49:54 UTC) #1
markus.icu
https://codereview.appspot.com/189460043/diff/20001/source/i18n/unicode/dtfmtsym.h File source/i18n/unicode/dtfmtsym.h (right): https://codereview.appspot.com/189460043/diff/20001/source/i18n/unicode/dtfmtsym.h#newcode441 source/i18n/unicode/dtfmtsym.h:441: #ifndef U_HIDE_DRAFT_API Please move this line to just before ...
9 years, 9 months ago (2015-02-17 17:11:44 UTC) #2
roubert (google)
https://codereview.appspot.com/189460043/diff/20001/source/i18n/unicode/dtfmtsym.h File source/i18n/unicode/dtfmtsym.h (right): https://codereview.appspot.com/189460043/diff/20001/source/i18n/unicode/dtfmtsym.h#newcode441 source/i18n/unicode/dtfmtsym.h:441: #ifndef U_HIDE_DRAFT_API On 2015/02/17 17:11:44, markus.icu wrote: > Please ...
9 years, 9 months ago (2015-02-18 16:39:46 UTC) #3
markus.icu
LGTM
9 years, 9 months ago (2015-02-19 00:08:57 UTC) #4
roubert (google)
9 years, 9 months ago (2015-02-19 12:03:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 37043 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b