Issue 1892053: remove invalid XML chars from multi-line diff AJAX response

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1892053: remove invalid XML chars from multi-line diff AJAX response

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by Jake McGuire

Modified:
15 years, 4 months ago

Reviewers:
Andi Albrecht

Base URL:
http://rietveld.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Some people put ^L in their source code files as a means of separating functions or whatever. ^L is not a valid XML character, so when we try to send it back in response to the AJAX request to show hidden lines in a side-by-side diff we get an ExpatError. There is no common function to remove illegal XML characters, so I created one and called it in the appropriate place.