Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 1891051: Rewrite only CSS links; Do no proxy empty resource. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by Kuntal Loya
Modified:
15 years, 5 months ago
Reviewers:
johnfargo, dev-remailer, shindig.remailer
CC:
cool-shindig-committers_googlegroups.com
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Only the LINK tags which have rel="stylesheet" and type="text/css" should be rewritten. Others should be bypassed. There can be resources, which have the resource url as empty string; those should be bypassed as well.

Patch Set 1 #

Total comments: 1

Messages

Total messages: 4
anupama.dutta
Good tests! LGTM. http://codereview.appspot.com/1891051/diff/1/2 File java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ProxyingVisitorTest.java (left): http://codereview.appspot.com/1891051/diff/1/2#oldcode33 java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/ProxyingVisitorTest.java:33: import static org.easymock.EasyMock.*; Retain these instead ...
15 years, 5 months ago (2010-08-09 11:02:16 UTC) #1
gagan.goku
On 2010/08/09 11:02:16, anupama.dutta wrote: > Good tests! > LGTM. > > http://codereview.appspot.com/1891051/diff/1/2 > File ...
15 years, 5 months ago (2010-08-09 12:42:28 UTC) #2
Kuntal Loya
Description : Only the LINK tags which have rel="stylesheet" and type="text/css" should be rewritten. Others ...
15 years, 5 months ago (2010-08-10 06:44:20 UTC) #3
johnfargo
15 years, 5 months ago (2010-08-11 18:47:57 UTC) #4
On 2010/08/10 06:44:20, Kuntal Loya wrote:
> Description : 
> 
> Only the LINK tags which have rel="stylesheet" and type="text/css" should be
> rewritten. Others should be bypassed.
> 
> There can be resources, which have the resource url as empty string; those
> should be bypassed as well.

LGTM, committed as r984526.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b