Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 189094: Add rules on sequences (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years ago by bch
Modified:
16 years ago
Reviewers:
ced, yangoon1
Visibility:
Public.

Description

Sequences can now only be accessed by groups added on the corresponding sequence type (like for editing padding or the current number). Root user is used to increment them.

Patch Set 1 #

Total comments: 7

Patch Set 2 : Use root user on get_id, handle strict sequences, added get_groups. #

Total comments: 1

Patch Set 3 : fix get_groups #

Total comments: 2

Patch Set 4 : Fix get_groups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -9 lines) Patch
M trytond/ir/sequence.py View 1 1 chunk +8 lines, -9 lines 0 comments Download
M trytond/res/ir.py View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
M trytond/res/ir.xml View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 13
bch
16 years ago (2010-01-15 21:53:13 UTC) #1
bch
16 years ago (2010-01-15 21:56:57 UTC) #2
ced
http://codereview.appspot.com/189094/diff/1/2 File trytond/ir/sequence.py (right): http://codereview.appspot.com/189094/diff/1/2#newcode136 trytond/ir/sequence.py:136: # bypass rules on sequences I will let the ...
16 years ago (2010-01-15 23:35:10 UTC) #3
yangoon1
16 years ago (2010-01-15 23:36:56 UTC) #4
ced
http://codereview.appspot.com/189094/diff/1/3 File trytond/res/ir.py (right): http://codereview.appspot.com/189094/diff/1/3#newcode157 trytond/res/ir.py:157: _name = 'ir.sequence' Need also for ir.sequence.strict http://codereview.appspot.com/189094/diff/1/4 File ...
16 years ago (2010-01-18 08:37:36 UTC) #5
bch
16 years ago (2010-01-18 15:03:36 UTC) #6
ced
http://codereview.appspot.com/189094/diff/1006/12 File trytond/res/ir.py (right): http://codereview.appspot.com/189094/diff/1006/12#newcode5 trytond/res/ir.py:5: from collections import defaultdict Only available since 2.5
16 years ago (2010-01-18 15:19:22 UTC) #7
bch
16 years ago (2010-01-18 15:32:31 UTC) #8
ced
http://codereview.appspot.com/189094/diff/16/18 File trytond/res/ir.py (right): http://codereview.appspot.com/189094/diff/16/18#newcode168 trytond/res/ir.py:168: code2seq = dict((s.code, s.id) for s in sequences) Only ...
16 years ago (2010-01-18 15:37:23 UTC) #9
bch
16 years ago (2010-01-18 15:53:03 UTC) #10
ced
http://codereview.appspot.com/189094/diff/16/18 File trytond/res/ir.py (right): http://codereview.appspot.com/189094/diff/16/18#newcode168 trytond/res/ir.py:168: code2seq = dict((s.code, s.id) for s in sequences) On ...
16 years ago (2010-01-18 16:23:08 UTC) #11
bch
> On 2010/01/18 15:37:23, ced wrote: > > Only works if code is unique. > ...
16 years ago (2010-01-18 16:25:09 UTC) #12
ced
16 years ago (2010-01-18 16:41:54 UTC) #13
On 2010/01/18 16:25:09, bch wrote:
> > On 2010/01/18 15:37:23, ced wrote:
> > > Only works if code is unique.
> > 
> > I would prefer to make a uniq constraint on code
> 
> What about accounting sequences that share the same code across periods ?

Yes that is true. I was thinking about ir.sequence.type
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b