Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 189044: Add a well known prefix for opensocial. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 5 months ago by MikeSamuel
Modified:
16 years, 3 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is pulled out of a larger CL, so apologies for the cruft. There are 2 major changes: (1) Changes to Namespaces to add well-known prefixes. (2) Changes to Nodes.render so that adding new prefixes won't change rendered output that doesn't use those namespaces. This makes test goldens more robust. Submitted @3998

Patch Set 1 #

Patch Set 2 : Add a well known prefix for opensocial. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -74 lines) Patch
M src/com/google/caja/opensocial/DefaultGadgetRewriter.java View 1 2 chunks +2 lines, -1 line 0 comments Download
D src/com/google/caja/opensocial/OpenSocialMessageType.java View 1 1 chunk +0 lines, -56 lines 0 comments Download
M src/com/google/caja/parser/html/Namespaces.java View 1 2 chunks +16 lines, -7 lines 0 comments Download
M src/com/google/caja/parser/html/Nodes.java View 1 1 chunk +12 lines, -2 lines 0 comments Download
M src/com/google/caja/plugin/PluginMessageType.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/com/google/caja/parser/html/NodesTest.java View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tests/com/google/caja/plugin/stages/LegacyNamespaceFixupStageTest.java View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
MikeSamuel
16 years, 5 months ago (2010-01-13 01:34:58 UTC) #1
MikeSamuel
ping
16 years, 5 months ago (2010-01-14 19:45:30 UTC) #2
Jasvir
16 years, 3 months ago (2010-03-02 19:58:14 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b