Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2310)

Issue 189040043: Bugs: #67, #68, #69, #70, single file parsing and changing version number to release (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by kiddi
Modified:
9 years, 11 months ago
Reviewers:
Joachim Metz
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

These files are missing unit tests: + plaso/__init__.py

Patch Set 1 #

Patch Set 2 : Uploading changes made to code. #

Total comments: 2

Patch Set 3 : Uploading changes made to code. #

Patch Set 4 : Uploading changes made to code. #

Patch Set 5 : Uploading changes made to code. #

Patch Set 6 : Submitted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -18 lines) Patch
M plaso/__init__.py View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M plaso/frontend/frontend.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/frontend/presets.py View 1 2 3 3 chunks +8 lines, -6 lines 0 comments Download
M plaso/parsers/chrome_cache.py View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download
M plaso/parsers/custom_destinations.py View 1 2 3 4 1 chunk +10 lines, -1 line 0 comments Download
M plaso/parsers/esedb_plugins/msie_webcache.py View 1 2 3 4 1 chunk +11 lines, -2 lines 0 comments Download
M plaso/parsers/oxml.py View 1 2 3 2 chunks +11 lines, -2 lines 0 comments Download
M plaso/parsers/text_parser.py View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M plaso/parsers/winprefetch.py View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 10
kiddi
9 years, 11 months ago (2014-12-15 22:50:12 UTC) #1
kiddi
Code updated.
9 years, 11 months ago (2014-12-16 00:29:00 UTC) #2
Joachim Metz
https://codereview.appspot.com/189040043/diff/20001/plaso/lib/binary.py File plaso/lib/binary.py (right): https://codereview.appspot.com/189040043/diff/20001/plaso/lib/binary.py#newcode248 plaso/lib/binary.py:248: logging.warning(( Move this out of this function. We need ...
9 years, 11 months ago (2014-12-16 08:31:01 UTC) #3
kiddi
done https://codereview.appspot.com/189040043/diff/20001/plaso/lib/binary.py File plaso/lib/binary.py (right): https://codereview.appspot.com/189040043/diff/20001/plaso/lib/binary.py#newcode248 plaso/lib/binary.py:248: logging.warning(( On 2014/12/16 08:31:01, Joachim Metz wrote: > ...
9 years, 11 months ago (2014-12-16 19:24:44 UTC) #4
kiddi
Code updated.
9 years, 11 months ago (2014-12-16 19:25:44 UTC) #5
kiddi
Code updated.
9 years, 11 months ago (2014-12-16 21:21:04 UTC) #6
kiddi
Code updated.
9 years, 11 months ago (2014-12-16 22:04:42 UTC) #7
kiddi
Code updated.
9 years, 11 months ago (2014-12-16 22:55:43 UTC) #8
Joachim Metz
LGTM
9 years, 11 months ago (2014-12-17 07:49:49 UTC) #9
kiddi
9 years, 11 months ago (2014-12-17 17:17:25 UTC) #10
Code Submitted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b