code review 188790043: x/talks/2014/readability: fix some typo

x/talks/2014/readability: fix some typo

[ukai, 2014-12-08 02:23:57]

Hello r@golang.org, adg@golang.org, minux@golang.org (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.talks/

[adg, 2014-12-08 02:25:39]

We're in the midst of the transition to git. Please hold this change until
after the migration, then I'll ask you to re-send the change as a gerrit
code review (instructions forthcoming).

Andrew

On 8 December 2014 at 13:23, <ukai@google.com> wrote:

> Reviewers: r, adg, minux,
>
> Message:
> Hello r@golang.org, adg@golang.org, minux@golang.org (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.talks/
>
>
> Description:
> x/talks/2014/readability: fix some typo
>
> Please review this at https://codereview.appspot.com/188790043/
>
> Affected files (+2, -2 lines):
>   M 2014/readability.slide
>   M 2014/readability/in-band-error.go
>
>
> Index: 2014/readability.slide
> ===================================================================
> --- a/2014/readability.slide
> +++ b/2014/readability.slide
> @@ -209,7 +209,7 @@
>
>  - [[https://golang.org/s/comments#Package_Names][SamplingServer in
> sampling package is stutter]]. Name `Server`, which clients will write as
> `sampling.Server`.
>  - Use [[https://golang.org/s/comments#Receiver_Names][one or two letters
> for receiver names]].
> -- Use short namse for parameters since type name will give some
> information.
> +- Use short names for parameters since type name will give some
> information.
>  - Use descriptive names for basic types, though.
>  - Use short names for local variables: prefer `i` to `index`, `r` to
> `reader`.
>  - Short names should be fine if function is not long.
> Index: 2014/readability/in-band-error.go
> ===================================================================
> --- a/2014/readability/in-band-error.go
> +++ b/2014/readability/in-band-error.go
> @@ -17,7 +17,7 @@
>         case -2:
>                 return -2 // HL
>         default:
> -               return time.Duation(durationUsec) * time.Microsecond // HL
> +               return time.Duration(durationUsec) * time.Microsecond // HL
>         }
>         return -3 // HL
>  }
>
>
>

[ukai, 2014-12-08 02:26:37]

On 2014/12/08 02:25:39, adg wrote:
> We're in the midst of the transition to git. Please hold this change until
> after the migration, then I'll ask you to re-send the change as a gerrit
> code review (instructions forthcoming).

ok, i see.

[gobot, 2014-12-19 05:17:35]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/188790043 is best) in the description in your
new CL.

Thanks very much.

[r, 2015-01-08 00:40:44]

Would you like to send this again now? We are now using git and gerrit's
code review setup. Details at http://golang.org/doc/contribute.html

Thanks.

-rob




On Mon, Dec 8, 2014 at 1:26 PM, <ukai@google.com> wrote:

> On 2014/12/08 02:25:39, adg wrote:
>
>> We're in the midst of the transition to git. Please hold this change
>>
> until
>
>> after the migration, then I'll ask you to re-send the change as a
>>
> gerrit
>
>> code review (instructions forthcoming).
>>
>
> ok, i see.
>
>
>
> https://codereview.appspot.com/188790043/
>

[minux, 2015-01-08 00:44:38]

This CL has been sent as https://go-review.googlesource.com/#/c/1874/, and
already merged.

[r, 2015-01-08 01:18:46]

Good. The site (talks.golang.org) needs refreshing then.

-rob


On Thu, Jan 8, 2015 at 11:44 AM, minux <minux@golang.org> wrote:

> This CL has been sent as https://go-review.googlesource.com/#/c/1874/, and
> already merged.
>

[adg, 2015-01-08 01:27:41]

It's now updated.

On 8 January 2015 at 12:18, Rob Pike <r@golang.org> wrote:

> Good. The site (talks.golang.org) needs refreshing then.
>
> -rob
>
>
> On Thu, Jan 8, 2015 at 11:44 AM, minux <minux@golang.org> wrote:
>
>> This CL has been sent as https://go-review.googlesource.com/#/c/1874/,
>> and
>> already merged.
>>
>
>