Issue 1883046: Replace ProxyBase.PARAM_CONSTANTS with UriCommon.Param

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1883046: Replace ProxyBase.PARAM_CONSTANTS with UriCommon.Param (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by johnfargo

Modified:
15 years, 5 months ago

Reviewers:
zhoresh, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Splitting easy-to-review files from CL: http://codereview.appspot.com/1696056/show

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+39 lines, -36 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/Gadget.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingProxyUriManager.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/old/ConcatLinkRewriter.java	View	3 chunks	+4 lines, -3 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/caja/old/CajaCssSanitizerTest.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriterTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingProxyUriManagerTest.java	View	4 chunks	+9 lines, -9 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingProxyUriManagerTest.java	View	4 chunks	+9 lines, -9 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/old/SanitizingGadgetRewriterTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServletTest.java	View	3 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 5

johnfargo

15 years, 5 months ago (2010-08-03 00:14:10 UTC) #5

On 2010/08/02 21:14:23, zhoresh wrote:
> LGTM++

committed