Issue 1879043: code review 1879043: Add support for encoding complex values to encoding/binary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1879043: code review 1879043: Add support for encoding complex values to encoding/binary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rog

Modified:
14 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Add support for encoding complex values to encoding/binary. Change the comments to make it clear that it encodes floats and complex too.

Patch Set 1 #

Patch Set 2 : code review 1879043: Fix encoding/binary comments to make it clear that it e... #

Patch Set 3 : code review 1879043: Add support for encoding complex values to encoding/binary. #

Patch Set 4 : code review 1879043: Add support for encoding complex values to encoding/binary. #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -27 lines)			Patch
	M	src/pkg/encoding/binary/binary.go	View	1 2	5 chunks	+37 lines, -11 lines	0 comments	Download
	M	src/pkg/encoding/binary/binary_test.go	View		4 chunks	+40 lines, -16 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rog

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-07-29 09:09:07 UTC) #1

rog

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 7 months ago (2010-07-30 12:09:13 UTC) #2

rsc

14 years, 7 months ago (2010-08-06 23:44:40 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=00785adc99e8 ***

encoding/binary: add complex

R=rsc
CC=golang-dev
http://codereview.appspot.com/1879043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages