Issue 187700043: Run ibus_bus_preload_engines_async 30 seconds later in ibus-ui-gtk3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 187700043: Run ibus_bus_preload_engines_async 30 seconds later in ibus-ui-gtk3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by fujiwara

Modified:
9 years, 5 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Run ibus_bus_preload_engines_async 30 seconds later in ibus-ui-gtk3 Make sure to run the primary ibus engine at first to avoid the duplicated IO. TEST=ui/gtk3/ibus-ui-gtk3

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with the latest. #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	ui/gtk3/panel.vala	View		2 chunks	+16 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peng

9 years, 5 months ago (2015-01-05 15:32:44 UTC) #2

lgtm

https://codereview.appspot.com/187700043/diff/1/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/187700043/diff/1/ui/gtk3/panel.vala#newcode69
ui/gtk3/panel.vala:69: private const uint PRELOAD_ENGINES_DELAY_TIME = 30000;
Please add a comment here.

Expand All Messages | Collapse All Messages