Make GWT template javascripts suitable for XHTML

With these modifications XHTML can be used with GWT. I managed to get the default app generated by webAppCreator to work while using an .xhtml file. The .js files now only use DOM statements like createElement and the .java files are updated to create elements lowercase which is required by XHTML. In the application source code generated by webAppCreator all I had to do is make the HTML fragments XHTML compliant.

[jgw, 2010-09-03 18:43:47]

Sorry for taking so long to look at this. It's a really tricky problem, because
of the way we used document.write()'s semantics. In particular, I believe some
features (like script injection) are simply impossible to implement correctly
without document.write().

However, there's another change getting ready to land that modifies the new
"cross-site iframe" linker to get rid of most calls to document.write(), which
you might be able to leverage to allow it to work with XHTML. It intentionally
doesn't support script injection, and it *will* use document.write() if you
don't provide a script base meta tag, or name your initial script in the
"standard" way.

http://gwt-code-reviews.appspot.com/810801

http://codereview.appspot.com/1873052/diff/5001/6001
File dev/core/src/com/google/gwt/core/ext/linker/impl/computeScriptBase.js
(right):

http://codereview.appspot.com/1873052/diff/5001/6001#newcode38
dev/core/src/com/google/gwt/core/ext/linker/impl/computeScriptBase.js:38:
$doc.getElementsByTagName('head')[0].appendChild(markerScript);
I'm pretty sure this won't do what you expect. The trick here was to leverage
the bizarre semantics of document.write(), which guarantee that the script
appended will end up precisely after the currently-evaluating script tag.

http://codereview.appspot.com/1873052/diff/5001/6002
File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):

http://codereview.appspot.com/1873052/diff/5001/6002#newcode347
dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js:347:
$doc.getElementsByTagName('head')[0].appendChild(deferScript);
I don't believe this will guarantee proper execution order. Appending this
script tag to the head will pretty much cause it to be executed whenever the
browser feels like it. The document.write() trick leverages the
currently-executing HTML parser to cause onInjectionDone() to be called only
once everything before it (including external scripts) has been evaluated.

[hfmanson, 2010-09-16 10:29:46]

On 2010/09/03 18:43:47, jgw wrote:
> Sorry for taking so long to look at this. It's a really tricky problem,
because
> of the way we used document.write()'s semantics. In particular, I believe some
> features (like script injection) are simply impossible to implement correctly
> without document.write().
> 
> However, there's another change getting ready to land that modifies the new
> "cross-site iframe" linker to get rid of most calls to document.write(), which
> you might be able to leverage to allow it to work with XHTML. It intentionally
> doesn't support script injection, and it *will* use document.write() if you
> don't provide a script base meta tag, or name your initial script in the
> "standard" way.
> 
> http://gwt-code-reviews.appspot.com/810801
> 
> http://codereview.appspot.com/1873052/diff/5001/6001
> File dev/core/src/com/google/gwt/core/ext/linker/impl/computeScriptBase.js
> (right):
> 
> http://codereview.appspot.com/1873052/diff/5001/6001#newcode38
> dev/core/src/com/google/gwt/core/ext/linker/impl/computeScriptBase.js:38:
> $doc.getElementsByTagName('head')[0].appendChild(markerScript);
> I'm pretty sure this won't do what you expect. The trick here was to leverage
> the bizarre semantics of document.write(), which guarantee that the script
> appended will end up precisely after the currently-evaluating script tag.
> 
> http://codereview.appspot.com/1873052/diff/5001/6002
> File dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (right):
> 
> http://codereview.appspot.com/1873052/diff/5001/6002#newcode347
> dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js:347:
> $doc.getElementsByTagName('head')[0].appendChild(deferScript);
> I don't believe this will guarantee proper execution order. Appending this
> script tag to the head will pretty much cause it to be executed whenever the
> browser feels like it. The document.write() trick leverages the
> currently-executing HTML parser to cause onInjectionDone() to be called only
> once everything before it (including external scripts) has been evaluated.

http://gwt-code-reviews.appspot.com/810801 does not exist, did you mean
http://gwt-code-reviews.appspot.com/807801/show ?

[jgw, 2010-09-16 13:28:45]

On 2010/09/16 10:29:46, hfmanson wrote:
> http://gwt-code-reviews.appspot.com/810801 does not exist, did you mean
> http://gwt-code-reviews.appspot.com/807801/show ?

Yes, that's correct. Sorry about that -- apparently I can't operate my cut
buffer correctly :)